forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Diwaker Gupta <diwakergu...@gmail.com>
Subject Re: using view/viewHelper
Date Sat, 16 Apr 2005 19:21:34 GMT
Awesome! While we're at it, I wonder why we have those elaborate color
definitions in skinconf.xml? Since we are going to use CSS for
skinning anyways, doesn't it make more sense to put the color
definitions into CSS as well? Just a thought.

On 4/16/05, Thorsten Scherler <thorsten@apache.org> wrote:
> On Fri, 2005-04-15 at 21:32 -0700, Diwaker Gupta wrote:
> > > I made some changes to add custom css to the view.
> >
> > Great!
> >
> > > <forrest:css url="someCss.css"/>
> > >
> > > This tag has to be direct son from forrest:view!
> > >
> > > In the above link you will find:
> > > <map:when test="{project:skins-dir}{path}/{name}.css">
> > >
> > > That means e.g.
> > > <forrest:css url="prosimii-screen-alt.css"/>
> > >
> > > would expect (with default values)
> > > src/documentation/skins
> > >  |-- css
> > >      `-- prosimii-screen-alt.css
> >
> > One small bug I discovered -- the generated HTML includes the
> > someName.css file *twice* for some reason:
> >
> > <xhtml xmlns:forrest="http://apache.org/forrest/templates/1.0"
> > xmlns:xi="http://www.w3.org/2001/XInclude"><head>
> > [snip]
> > <link href="skin/basic.css" rel="stylesheet" type="text/css" /><link
> > href="skin/contracts-index.css" rel="stylesheet" type="text/css" />
> > <link href="skin/default.css" rel="stylesheet" type="text/css" />
> >                     ^^^^^^^^^^^^^^^^
> > <title>Diwaker Gupta :: Home</title></head><body onload="init()">
> > <link href="skin/default.css" rel="stylesheet" type="text/css" />
> >                    ^^^^^^^^^^^^^^^^^
> >
> > Nothing bad in that of course, just redundant :) We should drive
> > forrest to perfection! Good work!
> 
> :)
> 
> I will have a look now. I guess it is because of
> http://svn.apache.org/viewcvs.cgi/forrest/trunk/plugins/org.apache.forrest.plugin.view/resources/stylesheets/prepare.xhtml.xsl?view=markup
> 
> There is a match that is matching twice.
> 
> Cheers for reporting the bug.
> 
> salu2
> --
> thorsten
> 
> "Together we stand, divided we fall!"
> Hey you (Pink Floyd)
> 
> 


-- 
Diwaker Gupta
http://resolute.ucsd.edu/diwaker

Mime
View raw message