forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thorsten Scherler <thors...@apache.org>
Subject Re: using view/viewHelper
Date Sat, 16 Apr 2005 20:32:19 GMT
That bug is fixed in trunk.

On Sat, 2005-04-16 at 15:59 +0200, Thorsten Scherler wrote:
> On Fri, 2005-04-15 at 21:32 -0700, Diwaker Gupta wrote:
> > > I made some changes to add custom css to the view.
> > 
> > Great!
> > 
> > > <forrest:css url="someCss.css"/>
> > > 
> > > This tag has to be direct son from forrest:view!
> > > 
> > > In the above link you will find:
> > > <map:when test="{project:skins-dir}{path}/{name}.css">
> > > 
> > > That means e.g.
> > > <forrest:css url="prosimii-screen-alt.css"/>
> > > 
> > > would expect (with default values)
> > > src/documentation/skins
> > >  |-- css
> > >      `-- prosimii-screen-alt.css
> > 
> > One small bug I discovered -- the generated HTML includes the
> > someName.css file *twice* for some reason:
> > 
> > <xhtml xmlns:forrest="http://apache.org/forrest/templates/1.0"
> > xmlns:xi="http://www.w3.org/2001/XInclude"><head>
> > [snip]
> > <link href="skin/basic.css" rel="stylesheet" type="text/css" /><link
> > href="skin/contracts-index.css" rel="stylesheet" type="text/css" />
> > <link href="skin/default.css" rel="stylesheet" type="text/css" />
> >                     ^^^^^^^^^^^^^^^^
> > <title>Diwaker Gupta :: Home</title></head><body onload="init()">
> > <link href="skin/default.css" rel="stylesheet" type="text/css" />
> >                    ^^^^^^^^^^^^^^^^^
> > 
> > Nothing bad in that of course, just redundant :) We should drive
> > forrest to perfection! Good work!
> 
> :)
> 
> I will have a look now. I guess it is because of
> http://svn.apache.org/viewcvs.cgi/forrest/trunk/plugins/org.apache.forrest.plugin.view/resources/stylesheets/prepare.xhtml.xsl?view=markup
> 
> There is a match that is matching twice. 
> 
> Cheers for reporting the bug.
> 
> salu2
-- 
thorsten

"Together we stand, divided we fall!" 
Hey you (Pink Floyd)


Mime
View raw message