Return-Path: 
 <dev-return-13956-apmail-forrest-dev-archive=forrest.apache.org@forrest.apache.org>
Delivered-To: apmail-forrest-dev-archive@www.apache.org
Received: (qmail 19523 invoked from network); 16 Nov 2004 19:01:53 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur-2.apache.org with SMTP; 16 Nov 2004 19:01:53 -0000
Received: (qmail 5142 invoked by uid 500); 16 Nov 2004 19:01:52 -0000
Delivered-To: apmail-forrest-dev-archive@forrest.apache.org
Received: (qmail 5105 invoked by uid 500); 16 Nov 2004 19:01:52 -0000
Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@forrest.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@forrest.apache.org>
list-post: <mailto:dev@forrest.apache.org>
Reply-To: dev@forrest.apache.org
Delivered-To: mailing list dev@forrest.apache.org
Received: (qmail 5093 invoked by uid 99); 16 Nov 2004 19:01:51 -0000
X-ASF-Spam-Status: No, hits=0.5 required=10.0
	tests=DNS_FROM_RFC_WHOIS,FORGED_RCVD_HELO,SPF_HELO_PASS
X-Spam-Check-By: apache.org
Received-SPF: neutral (hermes.apache.org: local policy)
Received: from [196.25.240.77] (HELO ctb-mesg5.saix.net) (196.25.240.77)
  by apache.org (qpsmtpd/0.28) with ESMTP; Tue, 16 Nov 2004 11:01:50 -0800
Received: from sean.site (ndn-75-166.telkomadsl.co.za [165.165.75.166])
	by ctb-mesg5.saix.net (Postfix) with ESMTP id 60D12DF1C
	for <dev@forrest.apache.org>; Tue, 16 Nov 2004 21:01:43 +0200 (SAST)
From: Sean Wheller <sean@inwords.co.za>
Reply-To: sean@inwords.co.za
Organization: In Words
To: dev@forrest.apache.org
Subject: Re: Selective PDF
Date: Tue, 16 Nov 2004 20:57:27 +0200
User-Agent: KMail/1.6.2
References: <200411141149.20071.sean@inwords.co.za>
 <200411161838.05593.sean@inwords.co.za> <419A36E0.8080103@apache.org>
In-Reply-To: <419A36E0.8080103@apache.org>
MIME-Version: 1.0
Content-Disposition: inline
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Message-Id: <200411162057.27547.sean@inwords.co.za>
X-Virus-Checked: Checked
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

On Tuesday 16 November 2004 19:20, Ross Gardler wrote:
> > and since we have a
> > pdf plugin it will be
>
> Actually, we don't have a PDF output plugin yet, but I'll knock it
> together when svn is working again.

Yep, we don't same with most other target formats.

>
> > plugin.pdf.button.include.output=3D**.html, documentation/index.html
> > plugin.pdf.button.exclude.output=3D**/index.html
> >
> > So if you have a pod plugin, then either the forrest.properties for the
> > pod plugin will have this defined or the main forrest.properties.
> >
> > plugin.pod.button.include.output=3D**.html, documentation/index.html
> > plugin.pod.button.exclude.output=3D**/index.html
> >
> > and so on for each target format ?
>
> Yes, or at least that is my thinking. We have to wait a short while to
> make sure there are no objections from anyone. We may have missed
> something.

Ok once I know which forrest.properties I will add for each target format.

I don't see an issue in JIRA for this so I can attach a patch (once I know=
=20
which file to modify :-) ), perhaps it's named something obscure?

>
> The next stage is where do we process these properties.

This is the part that has me stuck.

>
> Lets continue to use PDF as a use case. Currently, site2xhtml.xsl has
> the following:
>
> <!--+
> =A0 =A0 =A0|Generates the PDF link
> =A0 =A0 =A0+-->
> =A0 =A0<xsl:template match=3D"div[@id=3D'skinconf-pdflink']">
> =A0 =A0 =A0<xsl:if test=3D"not($config/disable-pdf-link) or $disable-pdf-=
link =3D
> 'false'">
> =A0 =A0 =A0 =A0<div class=3D"pdflink" title=3D"Portable Document Format">=
<a
> href=3D"{$filename-noext}.pdf" class=3D"dida">
> =A0 =A0 =A0 =A0 =A0<img class=3D"skin" src=3D"{$skin-img-dir}/pdfdoc.gif"=
 alt=3D"PDF
> -icon" /><br/>
> =A0 =A0 =A0 =A0 =A0PDF</a>
> =A0 =A0 =A0 =A0</div>
> =A0 =A0 =A0</xsl:if>
> =A0 =A0</xsl:template>
>
> We need to maintain this default behaviour (although we may want to
> deprecate it).

=46or now we must keep it, or it won't work. Same with the full-docbook plu=
gin I=20
have sitting with me, it won't work until XHTML. I guess we will come acros=
s=20
this problem more often as we move more things to plugins. Personal this is=
=20
why I would have liked XHTML implimented first and then everything else=20
developed. At least we would not have to go back and retouch all work.

> In addition, we want to consider the values of the new=20
> properties in the above template. How does this look?
>
>
> <!--+
> =A0 =A0 =A0|Generates the PDF link
> =A0 =A0 =A0+-->
<snip/> Some good logic

It looks sensible, as best I can tell. Will need to test it, but to have te=
st=20
env we need pdf plugin. So I think we:
1. do pdf plugin
2. add to forrest.properties (whichever it is)
3. add your logic to site2xhtml
=2D-=20
Sean Wheller
Technical Author
sean@inwords.co.za
http://www.inwords.co.za