Return-Path: 
 <dev-return-12989-apmail-forrest-dev-archive=forrest.apache.org@forrest.apache.org>
Delivered-To: apmail-forrest-dev-archive@www.apache.org
Received: (qmail 91606 invoked from network); 25 Oct 2004 13:13:54 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur-2.apache.org with SMTP; 25 Oct 2004 13:13:54 -0000
Received: (qmail 70692 invoked by uid 500); 25 Oct 2004 13:13:12 -0000
Delivered-To: apmail-forrest-dev-archive@forrest.apache.org
Received: (qmail 70575 invoked by uid 500); 25 Oct 2004 13:13:10 -0000
Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@forrest.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@forrest.apache.org>
list-post: <mailto:dev@forrest.apache.org>
Reply-To: dev@forrest.apache.org
Delivered-To: mailing list dev@forrest.apache.org
Received: (qmail 70405 invoked by uid 99); 25 Oct 2004 13:13:08 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: pass (hermes.apache.org: local policy)
Received: from [195.112.152.203] (HELO master.core.gen.tr) (195.112.152.203)
  by apache.org (qpsmtpd/0.28) with ESMTP; Mon, 25 Oct 2004 06:13:02 -0700
Received: from localhost (localhost [127.0.0.1])
	by master.core.gen.tr (Postfix) with ESMTP id 34E1138021
	for <dev@forrest.apache.org>; Mon, 25 Oct 2004 16:12:36 +0300 (EEST)
Received: from master.core.gen.tr ([127.0.0.1])
 by localhost (master [127.0.0.1]) (amavisd-new, port 10024) with ESMTP
 id 18731-01 for <dev@forrest.apache.org>;
 Mon, 25 Oct 2004 16:12:33 +0300 (EEST)
Received: from [195.112.152.202] (www2 [195.112.152.202])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by master.core.gen.tr (Postfix) with ESMTP id 992B938020
	for <dev@forrest.apache.org>; Mon, 25 Oct 2004 16:12:33 +0300 (EEST)
Message-ID: <417CFC2F.3050007@core.gen.tr>
Date: Mon, 25 Oct 2004 16:14:23 +0300
From: Evrim ULU <evrim@core.gen.tr>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7) Gecko/20040807
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: dev@forrest.apache.org
Subject: Re: forrestBot & tomcat
References: <417CEF99.5030505@core.gen.tr>
 <1098709203.417cf8d374ca6@secure.solidusdesign.com>
In-Reply-To: <1098709203.417cf8d374ca6@secure.solidusdesign.com>
X-Enigmail-Version: 0.84.1.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/mixed;
 boundary="------------090804040909000104050104"
X-Virus-Scanned: by amavisd-new at C0R3 Computer Security Group <core.gen.tr>
X-Virus-Checked: Checked
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

This is a multi-part message in MIME format.
--------------090804040909000104050104
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dave Brondsema wrote:
| Quoting Evrim ULU <evrim@core.gen.tr>:
|
| I don't think anybody has been interested in that before.  It's a good
idea,
| though.  If you'd like to provide a patch for it, that'd be great.
|
I'll provide it asap.

|
| I'm not sure what you mean, but I am interested.  Send along the patch
and I'll
| probably be able to understand better.

Forrestbot checks out only from pserver cvs. We'r using ssh as a cvs_rsh
so pserver is unadequate. I've attached the patch.

It defines <property name="getsrc.cvs.type" value="pserver"/> variable.
Value can be replaced with ext (+ export CVS_RSH="ssh") to use ssh as a
cvs rshell. Replacement must be done in you projects forrestbot build.xml.

Btw, i've removed "-l" parameter from checkout, it seems not working for me.

Evrim.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFBfPwuR2rUfDW+YFIRAg3aAJ4rfR7st7FUVYz0jzJZsfxWqYJLlgCeM9Jl
tcIVvA0kt4js88y6mRSvLOE=
=/Myh
-----END PGP SIGNATURE-----

--------------090804040909000104050104
Content-Type: text/x-patch;
 name="forrest-0.6.cvs_rsh.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="forrest-0.6.cvs_rsh.patch"

--- /home/evrim/forrest/apache-forrest-0.6-orig/src/forrestbot/core/getsrc.xml	2004-10-10 20:07:03.000000000 +0300
+++ getsrc.xml	2004-10-20 20:32:59.000000000 +0300
@@ -28,6 +28,7 @@
   </target>
 
   <!-- default values -->
+  <property name="getsrc.cvs.type" value="pserver"/>
   <property name="getsrc.cvs.user" value="anoncvs"/>
   <property name="getsrc.cvs.password" value="anoncvs"/>
   <property name="getsrc.cvs.root" value="/home/cvspublic"/>
@@ -39,23 +40,23 @@
 
   <target name="getsrc.cvs" description="FB: Get source from a CVS repository">
 
-    <cvspass cvsroot=":pserver:${getsrc.cvs.user}@${getsrc.cvs.host}:${getsrc.cvs.root}" password="${getsrc.cvs.password}"/>
+    <cvspass cvsroot=":${getsrc.cvs.type}:${getsrc.cvs.user}@${getsrc.cvs.host}:${getsrc.cvs.root}" password="${getsrc.cvs.password}"/>
 
     <!-- non-recursive; just to get forrest.properties -->
-    <echo><![CDATA[<cvs cvsRoot=":pserver:${getsrc.cvs.user}@${getsrc.cvs.host}:${getsrc.cvs.root}"
+    <echo><![CDATA[<cvs cvsRoot=":${getsrc.cvs.type}:${getsrc.cvs.user}@${getsrc.cvs.host}:${getsrc.cvs.root}"
       package="${getsrc.cvs.module}"
       dest="${build.cvsmodule-dir}"
       quiet="false"
-      command="checkout -l"
+      command="checkout"
       tag="${getsrc.cvs.tag}"
       failonerror="true"
       />]]></echo>
 
-    <cvs cvsRoot=":pserver:${getsrc.cvs.user}@${getsrc.cvs.host}:${getsrc.cvs.root}"
+    <cvs cvsRoot=":${getsrc.cvs.type}:${getsrc.cvs.user}@${getsrc.cvs.host}:${getsrc.cvs.root}"
       package="${getsrc.cvs.module}"
       dest="${build.cvsmodule-dir}"
       quiet="true"
-      command="checkout -l"
+      command="checkout"
       tag="${getsrc.cvs.tag}"
       failonerror="true"
       />
@@ -65,7 +66,7 @@
     <loadproperties srcFile="${forrest.home}/context/default-forrest.properties"/>
 
     <!-- only the project.content-dir directory -->
-    <echo><![CDATA[<cvs cvsRoot=":pserver:${getsrc.cvs.user}@${getsrc.cvs.host}:${getsrc.cvs.root}"
+    <echo><![CDATA[<cvs cvsRoot=":${getsrc.cvs.type}:${getsrc.cvs.user}@${getsrc.cvs.host}:${getsrc.cvs.root}"
       package="${getsrc.cvs.module}/${project.content-dir}"
       dest="${build.cvsmodule-dir}"
       quiet="false"
@@ -73,7 +74,7 @@
       failonerror="true"
       />]]></echo>
 
-    <cvs cvsRoot=":pserver:${getsrc.cvs.user}@${getsrc.cvs.host}:${getsrc.cvs.root}"
+    <cvs cvsRoot=":${getsrc.cvs.type}:${getsrc.cvs.user}@${getsrc.cvs.host}:${getsrc.cvs.root}"
       package="${getsrc.cvs.module}/${project.content-dir}"
       dest="${build.cvsmodule-dir}"
       quiet="true"

--------------090804040909000104050104--