forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Diwaker Gupta <diwakergu...@gmail.com>
Subject Re: svn commit: rev 56151 - in forrest/trunk: . etc etc/applied_patches etc/cocoon_upgrade forrestcore forrestcore/etc forrestcore/lib forrestcore/src/core forrestcore/src/core/bin forrestcore/tools/ant forrestcore/tools/dtdconverters forrestcore/too
Date Sun, 31 Oct 2004 22:28:37 GMT
> That means _moving_ legal, lib, etc and tools in the base Forrest dir.
> I'm also getting ready to move the bin dir in the root (as already
> discussed).

I don't know if you're planning to fix this, but the current build.xml
is broken:
<snip>
    <property name="build.dir"             location="../build"/>
</snip>

$ ./build.sh
BUILD FAILED
/home/diwaker/software/forrest/forrestcore/build.xml:52:
/home/diwaker/software/forrest/build/build.number doesn't exist and
new file can't be created.

Manually creating the build directory fixes this. A better solution of
course is to create the directory if it doesn't exist. The <mkdir>
target is already there, but it gets called *after* the <buildnumber>
target, which obviously fails since the directory doesn't exist yet.
This fixes it:

Index: build.xml
===================================================================
--- build.xml   (revision 56161)
+++ build.xml   (working copy)
@@ -49,6 +49,8 @@

     <property name="forrestbot.dir"         location="../tools/forrestbot"/>

+    <mkdir dir="${build.dir}"/>
+
     <buildnumber file="${build.dir}/build.number"/>
     <echo>
       --------------------------------------------------------------
@@ -66,8 +68,6 @@
       --------------------------------------------------------------
     </echo>

-    <mkdir dir="${build.dir}"/>
-
     <path id="classpath">
       <fileset dir="../lib" includes="**/*.jar"/>
       <fileset dir="${tools.dir}/jetty" includes="servlet*.jar"/>

-- 
Diwaker Gupta
http://resolute.ucsd.edu/diwaker

Mime
View raw message