From dev-return-12414-apmail-forrest-dev-archive=forrest.apache.org@forrest.apache.org Thu Sep 30 14:38:34 2004 Return-Path: Delivered-To: apmail-forrest-dev-archive@www.apache.org Received: (qmail 88628 invoked from network); 30 Sep 2004 14:38:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 30 Sep 2004 14:38:34 -0000 Received: (qmail 33772 invoked by uid 500); 30 Sep 2004 14:38:32 -0000 Delivered-To: apmail-forrest-dev-archive@forrest.apache.org Received: (qmail 33730 invoked by uid 500); 30 Sep 2004 14:38:31 -0000 Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: dev@forrest.apache.org Delivered-To: mailing list dev@forrest.apache.org Received: (qmail 33716 invoked by uid 99); 30 Sep 2004 14:38:31 -0000 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=INFO_TLD X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from [65.104.121.53] (HELO mail.medata.com) (65.104.121.53) by apache.org (qpsmtpd/0.28) with ESMTP; Thu, 30 Sep 2004 07:38:30 -0700 Received: from [172.24.2.66] ([172.24.2.66]) (authenticated bits=0) by mail.medata.com (8.12.8/8.12.8) with ESMTP id i8UEcQmp007900 for ; Thu, 30 Sep 2004 07:38:26 -0700 Mime-Version: 1.0 (Apple Message framework v619) In-Reply-To: <1096525577.19659.283.camel@ighp> References: <1096525577.19659.283.camel@ighp> Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <62BCCE44-12EE-11D9-B4BA-00039385397E@medata.com> Content-Transfer-Encoding: 7bit From: Clay Leeds Subject: Re: remove browser-dependent javascript - window print Date: Thu, 30 Sep 2004 07:38:25 -0700 To: dev@forrest.apache.org X-Mailer: Apple Mail (2.619) X-Virus-Scanned: ClamAV 0.80rc3/508/Tue Sep 28 11:44:49 2004 clamav-milter version 0.80c on mail.medata.com X-Virus-Status: Clean X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N On Sep 29, 2004, at 11:26 PM, David Crossley wrote: > There is some nasty code in Forrest [1] to try to enable > old M$ browsers to print the current window. This option is > only presented when they set skinconf/disable-print-link=false > > It tries to use "javascript:window.print()" and if that > fails then it tries some M$ gobbledegook. > > Doing some research, i see that more recent browsers > do use the window.print ability. Google found me this: > http://webcoder.info/reference/BrowserFiltering.script.html > > The only missing one that we would care about is Safari > on the Mac. More Googling showed that Safari gained that > capability on 2003-11-16 in Safari-1.1.5 If you want it tested, put up a page with the change and send me a link. I use Mac OS X 10.3.5 which comes with Safari 1.2.3 (v125.9). > Considering that Forrest is targetting newer browsers > with our CSS drive, it seems appropriate. > > The main reason that i want to remove this, is that we need > to ensure that our codebase is free of any license issues. > The origin of this code snippet is dubious, so i want to be > rid of it. > > Projects can always patch it back in if they want it. > > So i propose to go ahead and remove it soon. > > [1] src/core/context/skins/common/xslt/html/site2xhtml.xsl > and ditto for "tigris". > > -- > David Crossley Sounds like a good plan to me. Are there any other M$-specific code snippets in there we can be rid of? :-)