forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Clay Leeds <cle...@medata.com>
Subject Re: remove browser-dependent javascript - window print
Date Thu, 30 Sep 2004 14:38:25 GMT
On Sep 29, 2004, at 11:26 PM, David Crossley wrote:
> There is some nasty code in Forrest [1] to try to enable
> old M$ browsers to print the current window. This option is
> only presented when they set skinconf/disable-print-link=false
>
> It tries to use "javascript:window.print()" and if that
> fails then it tries some M$ gobbledegook.
>
> Doing some research, i see that more recent browsers
> do use the window.print ability. Google found me this:
> http://webcoder.info/reference/BrowserFiltering.script.html
>
> The only missing one that we would care about is Safari
> on the Mac. More Googling showed that Safari gained that
> capability on 2003-11-16 in Safari-1.1.5

If you want it tested, put up a page with the change and send me a 
link. I use Mac OS X 10.3.5 which comes with Safari 1.2.3 (v125.9).

> Considering that Forrest is targetting newer browsers
> with our CSS drive, it seems appropriate.
>
> The main reason that i want to remove this, is that we need
> to ensure that our codebase is free of any license issues.
> The origin of this code snippet is dubious, so i want to be
> rid of it.
>
> Projects can always patch it back in if they want it.
>
> So i propose to go ahead and remove it soon.
>
> [1] src/core/context/skins/common/xslt/html/site2xhtml.xsl
> and ditto for "tigris".
>
> -- 
> David Crossley

Sounds like a good plan to me. Are there any other M$-specific code 
snippets in there we can be rid of?

:-)


Mime
View raw message