forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dave Brondsema <d...@brondsema.net>
Subject Re: svn commit: rev 46087 - forrest/trunk/src/core/context/resources/chaperon/stylesheets
Date Fri, 17 Sep 2004 17:52:45 GMT
Fabio Rinaldi wrote:
> Dave Brondsema writes:
>  > Quoting David Crossley <crossley@apache.org>:
>  > 
>  > > Ah, okay. Thanks for watching diffs closely.
>  > > As far as i can see, that functionality still remains.
>  > > I gather that the logic was duplicated and Fabio's patch
>  > > moves it into a called template.
>  > 
>  > You're right.  I just looked at the diff an saw the removal of the logic without
>  > a corresponding addition.  But looking at the whole file now I see it must've
>  > been duplicated earlier.
> 
> Yes, it was a perfect duplicate (the only difference being the name of
> a parameter). I checked it very carefully before replacing it. The new
> template "convertLinks" just avoids redundancy, but it is otherwise
> equivalent. 
> 
> The only real difference is the following:
> 
>  > +    <xsl:variable name="href">
>  > +      <xsl:value-of
>  > +	select="normalize-space($href0)"/>
>  > +    </xsl:variable>
> 
> which has the purpose of removing spaces to the left or the right of
> the "href", e.g. if $href==" http://www.xxx.yy/ ", it will be changed
> to $href=="http://www.xxx.yy/". 
> 
> This has the possibly undesired side-effect that also spaces internal
> to the URL are 'normalized', i.e. multiple spaces are collapsed to a
> single space, e.g. "http://www.xxx.yy/   something" becomes 
> "http://www.xxx.yy/ something". 
> 
> I assume that a sequence of multiple spaces in a URL is very
> unlikely. However, if this effect is undesidered, then you should
> change the function "normalize-space" with something more suitable,
> which removes spaces either side of the URL, but does not otherwise
> modify the URL. I used "normalize-space" because I could not find a
> better way to do it.
> 
> Best,
> Fabio
> 

Thanks for that explanation.  I think it'll be fine.

If I have time sometime I'll test the good jspwiki changes that have 
been happening against the files we have at work.

-- 
Dave Brondsema : dave@brondsema.net
http://www.splike.com : programming
http://csx.calvin.edu : student org
http://www.brondsema.net : personal

Mime
View raw message