Return-Path: 
 <dev-return-11776-apmail-forrest-dev-archive=forrest.apache.org@forrest.apache.org>
Delivered-To: apmail-forrest-dev-archive@www.apache.org
Received: (qmail 64981 invoked from network); 15 Aug 2004 14:57:38 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur-2.apache.org with SMTP; 15 Aug 2004 14:57:38 -0000
Received: (qmail 5602 invoked by uid 500); 15 Aug 2004 14:57:36 -0000
Delivered-To: apmail-forrest-dev-archive@forrest.apache.org
Received: (qmail 5563 invoked by uid 500); 15 Aug 2004 14:57:36 -0000
Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@forrest.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@forrest.apache.org>
list-post: <mailto:dev@forrest.apache.org>
Reply-To: dev@forrest.apache.org
Delivered-To: mailing list dev@forrest.apache.org
Received: (qmail 5547 invoked by uid 99); 15 Aug 2004 14:57:35 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received: from [129.241.190.230] (HELO royk.itea.ntnu.no) (129.241.190.230)
  by apache.org (qpsmtpd/0.27.1) with ESMTP; Sun, 15 Aug 2004 07:57:31 -0700
Received: from localhost (localhost [127.0.0.1])
	by royk.itea.ntnu.no (Postfix) with ESMTP id 75CF466CFE
	for <dev@forrest.apache.org>; Sun, 15 Aug 2004 16:57:24 +0200 (CEST)
Received: from [10.0.0.9] (vpn-21622.vpn-s.ntnu.no [129.241.216.22])
	by royk.itea.ntnu.no (Postfix) with ESMTP
	for <dev@forrest.apache.org>; Sun, 15 Aug 2004 16:57:24 +0200 (CEST)
Mime-Version: 1.0 (Apple Message framework v618)
In-Reply-To: <1092546704.24718.71217.camel@ighp>
References: <20040815044323.29061.qmail@minotaur.apache.org>
 <1092546704.24718.71217.camel@ighp>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Message-Id: <68ACE40A-EECB-11D8-BB9F-000A95D7E5AC@stud.ntnu.no>
Content-Transfer-Encoding: quoted-printable
From: =?ISO-8859-1?Q?Eirik_Bj=F8rsn=F8s?= <bjorsnos@stud.ntnu.no>
Subject: Re: Please not hard-coded tabs in SVN
Date: Sun, 15 Aug 2004 16:57:20 +0200
To: dev@forrest.apache.org
X-Mailer: Apple Mail (2.618)
X-Content-Scanned: with sophos and spamassassin at mailgw.ntnu.no.
X-Virus-Checked: Checked
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N


> Not to pick on you Thorsten, but your commits have been
> adding hard-coded tab markers into otherwise tab-free files.

David,

Why not set up a pre-commit check script in SVN that scans all commited=20=

files for tabs and abort the commit if it finds any?

We've been doing this in a project I'm in (using CVS),  with great=20
success.  I'm sure it's possible to implement something similar using=20
Subversion.

Here's the perl script we're using:

# Scan all files
foreach $file (@ARGV) {
     if ($file =3D~ /.java/) {
         open(FILEHANDLE, $file);
         $line =3D 0;
         while (<FILEHANDLE>) {
             $line++;
             if (/\t/) {
                 print("Tab detected on line $line in file $file:\n$_");
                 print("Please remove it and try again\n");
                 exit(1);
             }
         }
         close(FILEHANDLE);
     }
}

Checking should be disabled for binary files, though.

Eirik.
--=20
Eirik Bj=F8rsn=F8s=