Return-Path: 
 <dev-return-11769-apmail-forrest-dev-archive=forrest.apache.org@forrest.apache.org>
Delivered-To: apmail-forrest-dev-archive@www.apache.org
Received: (qmail 31622 invoked from network); 15 Aug 2004 04:54:46 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur-2.apache.org with SMTP; 15 Aug 2004 04:54:46 -0000
Received: (qmail 46332 invoked by uid 500); 15 Aug 2004 04:54:45 -0000
Delivered-To: apmail-forrest-dev-archive@forrest.apache.org
Received: (qmail 46316 invoked by uid 500); 15 Aug 2004 04:54:45 -0000
Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:dev-help@forrest.apache.org>
list-unsubscribe: <mailto:dev-unsubscribe@forrest.apache.org>
list-post: <mailto:dev@forrest.apache.org>
Reply-To: dev@forrest.apache.org
Delivered-To: mailing list dev@forrest.apache.org
Received: (qmail 46305 invoked by uid 99); 15 Aug 2004 04:54:45 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received: from [65.77.211.93] (HELO indexgeo.net) (65.77.211.93)
  by apache.org (qpsmtpd/0.27.1) with ESMTP; Sat, 14 Aug 2004 21:54:42 -0700
Received: from [192.168.1.100] (dsl-109.227.240.220.dsl.comindico.com.au
 [220.240.227.109])
	(authenticated bits=0)
	by www2.kc.aoindustries.com (8.12.9-20030917/8.12.9) with ESMTP id
 i7F4sbEv014895
	for <dev@forrest.apache.org>; Sat, 14 Aug 2004 23:54:40 -0500
Subject: Re: [help] looping in pelt-dev
From: David Crossley <crossley@apache.org>
To: dev@forrest.apache.org
In-Reply-To: <cfma8u$onq$1@sea.gmane.org>
References: <411D84E9.4010207@apache.org>  <cfma8u$onq$1@sea.gmane.org>
Content-Type: text/plain
Organization: 
Message-Id: <1092545654.24717.71095.camel@ighp>
Mime-Version: 1.0
X-Mailer: Ximian Evolution 1.2.2 (1.2.2-5) 
Date: 15 Aug 2004 14:54:22 +1000
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N

Nicola Ken Barozzi wrote:
> Scherler, Thorsten wrote:
> 
> > Hello devs, hello user,
> > 
> > I am trying to track down the looping behaviour of the pelt dev skin!
> > 
> > I noticed that the loop happends when
> > the following conditions are fullfield:
> > 1) the looping node is a child of a node that has the attribute e.g. 
> > href="docs/" tab="docs".
> > 2) the looping node e.g. <document-v13 label="document-v13" 
> > href="document-v13.html"/> has both attributes "label" and "href".
> 
> I started by testing if this really happens, and it does.
> 
> > but sometimes I get: * [60/68] [2/56] 2.204s 90.3Kb 
> > docs/docs/docs/docs/docs/docs/docs/docs/document-v13.dtdx.html That
> > should be BROKEN (like before) because the file does not exists in 
> > that loaction either. This is an example of a node calling an endless
> > loop!
> 
> The CLI works on links. If it loops, it means that a file references 
> itself incorrectly, and the CLI uses that link.
> 
> So I looked in the page for 'document-v13.dtdx.html' and found this:
> 
>    <a id="feedbackto" href="docs/document-v13.dtdx.html"></a>
> 
> Here it is: document-v13.dtdx.html reference itself incorrectly, with a 
> docs/ before it. The correct link should be (relative):
> 
>    <a id="feedbackto" href="document-v13.dtdx.html"></a>
> 
> or (absolute):
> 
>    <a id="feedbackto" href="/docs/document-v13.dtdx.html"></a>

Ah, well found. This is actually due to another error.
The pelt-dev was partially rendering an optional skinconf element
i.e. not checking that the optional feedback element was available.
Those hrefs should be "mailto:" links with the path appended,
but our forrest core skinconf.xml deliberately does not have that
"feedback" configuration.

The pelt-dev is fixed now, and the never ending descending is gone.

However, now there is a different issue with all skins.

-- 
David Crossley