forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scherler, Thorsten" <thors...@apache.org>
Subject Re: Please not hard-coded tabs in SVN
Date Sun, 15 Aug 2004 15:33:45 GMT
David Crossley wrote:
> Not to pick on you Thorsten, but your commits have been
> adding hard-coded tab markers into otherwise tab-free files.
> 

Ok, I will prevend pressing "tab" ;-).

King regards
thorsten


> These whitespace issues are a nightmare. We tried
> to address it at Cocoon a while ago and after a huge
> discussion, we came up with some very minimal guidelines
> and tips for committers.
> http://cocoon.apache.org/community/committer.html#whitespace
> 
> --David
> 
> 
>>Author: thorsten
>>Date: Sat Aug 14 21:43:22 2004
>>New Revision: 36403
>>
>>Modified:
>>   forrest/trunk/src/core/context/skins/pelt-dev/xslt/html/site2xhtml.xsl
>>Log:
>>fixed the looping behaviour :) Thanks to Nicola Ken Barozzi.
>>
>>
>>Modified: forrest/trunk/src/core/context/skins/pelt-dev/xslt/html/site2xhtml.xsl
>>==============================================================================
>>--- forrest/trunk/src/core/context/skins/pelt-dev/xslt/html/site2xhtml.xsl	(original)
>>+++ forrest/trunk/src/core/context/skins/pelt-dev/xslt/html/site2xhtml.xsl	Sat Aug
14 21:43:22 2004
>>@@ -304,7 +304,8 @@
>>               </xsl:call-template>
>>             </div>
>>           </xsl:if>
>>-          <div id="feedback">
>>+		<xsl:if test="$config/feedback and not($config/feedback = '')">
>>+		  <div id="feedback">
>>             <xsl:value-of select="$config/feedback"/>
>>             <a id="feedbackto">
>>               <xsl:attribute name="href">
>>@@ -314,6 +315,7 @@
>>               <xsl:value-of select="$config/feedback/@to"/>
>>             </a>
>>           </div>
>>+		</xsl:if>
>> <xsl:comment>+
>>     |end bottomstrip
>>     +</xsl:comment>
> 
> 
> 


Mime
View raw message