Return-Path: Delivered-To: apmail-forrest-dev-archive@www.apache.org Received: (qmail 36495 invoked from network); 30 Jul 2004 00:43:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 30 Jul 2004 00:43:42 -0000 Received: (qmail 68034 invoked by uid 500); 30 Jul 2004 00:43:41 -0000 Delivered-To: apmail-forrest-dev-archive@forrest.apache.org Received: (qmail 67964 invoked by uid 500); 30 Jul 2004 00:43:40 -0000 Mailing-List: contact dev-help@forrest.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: list-post: Reply-To: dev@forrest.apache.org Delivered-To: mailing list dev@forrest.apache.org Received: (qmail 67951 invoked by uid 99); 30 Jul 2004 00:43:40 -0000 X-ASF-Spam-Status: No, hits=1.3 required=10.0 tests=RCVD_BY_IP,SB_NEW_BULK,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received: from [64.233.170.200] (HELO mproxy.gmail.com) (64.233.170.200) by apache.org (qpsmtpd/0.27.1) with ESMTP; Thu, 29 Jul 2004 17:43:37 -0700 Received: by mproxy.gmail.com with SMTP id v18so11824rnb for ; Thu, 29 Jul 2004 17:43:29 -0700 (PDT) Received: by 10.38.1.62 with SMTP id 62mr524959rna; Thu, 29 Jul 2004 17:43:29 -0700 (PDT) Message-ID: <1b0b455704072917431391e906@mail.gmail.com> Date: Thu, 29 Jul 2004 17:43:29 -0700 From: Diwaker Gupta To: dev@forrest.apache.org Subject: tigris-style cleanup Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_35_20946056.1091148209043" X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N ------=_Part_35_20946056.1091148209043 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline The current tigris style needs a lot of cleanup: o It doesn't use rounded corners, but the CSS still includes background images, which are the not copied into the images directory thereby resulting in a huge number of needless 404s o I think the inst.css is redundant and shud be discarded. inst.css was meant for customization on top of the default tigris.css -- however, this can be better handled by the extra-css option in skinconf.xml I'm attaching patch which comments out all the unused images included by the CSS files in tigris-style There are other issues which are not tigris-style specific -- like why are forrest.css.xslt and skinconf.xsl copied over to the deployment location? They're not required there, and therefore should not be copied. Go forrest! Diwaker -- Diwaker Gupta http://resolute.ucsd.edu/diwaker ------=_Part_35_20946056.1091148209043 Content-Type: text/plain; name="patch.txt" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="patch.txt" Index: src/core/context/skins/tigris-style-1_1/css/inst.css =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- src/core/context/skins/tigris-style-1_1/css/inst.css=09(revision 30954) +++ src/core/context/skins/tigris-style-1_1/css/inst.css=09(working copy) @@ -15,34 +15,37 @@ */ /* =20 -This file contains rules that extend or override the more basic formatting= defined in tigris.css. Edit it to customize the look of applications using= tigris.css (instances). You are responsible for maintaining your own set o= f (optional) deltas from tigris.css defaults; this file is intended as an e= xample. - +This file contains rules that extend or override the more basic formatting +defined in tigris.css. Edit it to customize the look of applications using +tigris.css (instances). You are responsible for maintaining your own set o= f +(optional) deltas from tigris.css defaults; this file is intended as an +example. */ =20 /* colors, backgrounds, borders, link indication */ #cn { -=09background-image: url(../images/corporate_logo.gif); +/*=09background-image: url(../images/corporate_logo.gif); */ =09display: block; =09height: 17px; =09width: 138px; } =20 #poweredby { -=09background-image: url(../images/poweredby_036.gif); +/*=09background-image: url(../images/poweredby_036.gif); */ =09display: block; =09height: 38px; =09width: 102px; } =20 #sc { -=09background-image: url(../images/product_logo.gif); +/*=09background-image: url(../images/product_logo.gif); */ =09display: block; =09height: 25px; =09width: 138px; } =20 #toptabs td, #toptabs th { -=09background-image: url(../images/nw_min_036.gif); +/* background-image: url(../images/nw_min_036.gif); */ } =20 .app h3, #banner, #banner td, #toptabs { Index: src/core/context/skins/tigris-style-1_1/css/forrest.css.xslt =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- src/core/context/skins/tigris-style-1_1/css/forrest.css.xslt=09(revisio= n 30954) +++ src/core/context/skins/tigris-style-1_1/css/forrest.css.xslt=09(working= copy) @@ -26,7 +26,9 @@ =20 #toptabs td{ -=09background-image: url('images/rc-t-l-10-1header-2tab-unselected-3tab-un= selected.png'); + =20 - + =20 ------=_Part_35_20946056.1091148209043--