forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From iss...@cocoondev.org
Subject [issues] New comment: (FOR-231) tigris-style css validation patch
Date Thu, 01 Jan 1970 00:00:00 GMT
The following comment has been added to this issue:

     Author: Diwaker Gupta
    Created: Sat, 31 Jul 2004 12:04 AM
       Body:
The only valid values for the display properties are:
block | inline | list-item | none
(source: http://htmlhelp.com/reference/css/classification/display.html)

Thats why I removed the display: inline-block line. We can set it to "initial" or "block"
instead.

I agree removing the height and the width fields was ugly. I guess I was more in a hacking
mode rather than "fixing" mode when I made that patch. Problem was that the XSL code used
for generating the height and width values is not working properly -- it was giving a blank
value. It should always return some sensible value (like 0 or something) but instead it just
returned an empty string. As a result, the generated CSS had something like:

height: px;
width: px;

with no numbers in them. This failed validation. I'm not very proficient in XSL, but I guess
it shouldn't be too hard to assign some default values.
---------------------------------------------------------------------
View the issue:

  http://issues.cocoondev.org/jira//secure/ViewIssue.jspa?key=FOR-231


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-231
    Summary: tigris-style css validation patch
       Type: Improvement

     Status: Unassigned
   Priority: Minor

    Project: Forrest
  Component: Forrest skins
   Versions:
             0.6

   Assignee: 
   Reporter: Diwaker Gupta

    Created: Wed, 28 Jul 2004 2:36 AM
    Updated: Wed, 28 Jul 2004 2:37 AM
Environment: Debian unstable
Linux resolute 2.6.7-1-686-smp #1 SMP Thu Jul 8 06:08:37 EDT 2004 i686 GNU/Linux

Description:
This patch makes the tigris-style skin CSS validate. The CSS still has a lot of redundant
and vestigial descriptions which are not needed by the skin anymore. I shall be submitting
cleanup patches for them shortly.


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org/jira//Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Mime
View raw message