forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nicola Ken Barozzi <nicola...@apache.org>
Subject Re: cvs commit: xml-forrest/src/core forrest.build.xml
Date Tue, 03 Feb 2004 16:22:52 GMT
Dave Brondsema wrote:
> On Tue, 3 Feb 2004, Dave Brondsema wrote:
> 
> 
>>On Thu, 29 Jan 2004 cheche@apache.org wrote:
>>
>>
>>>  Modified:    .        status.xml
>>>               src/core forrest.build.xml
>>>  Added:       src/targets webapp.xml war.xml validate.xml site.xml
>>>  Log:
>>>  Split build file into site,validate,war,webapp
>>>
>>
>>What's the rationale for this?  Just to organize the build better?  Or is
>>there a technical advantage too?

AFAIK it's just for build organization.

>>Would it make sense for me to put all the skin tasks into a seperate file?

Yes, it would be nice.

> Looking at this more, I see a big problem:
> 
>   <property name="targets-dir" value="../../../src/targets"/>
> 
>   <import file="${targets-dir}/validate.xml"/>
>   <import file="${targets-dir}/webapp.xml"/>
>   <import file="${targets-dir}/war.xml"/>
>   <import file="${targets-dir}/site.xml"/>
> 
> When we create a distributable targets-dir won't reference an existing
> directory.  The target buildfiles are not even included in the
> distributable.

Right, they should be here IMHO:

    <property name="targets-dir" location="targets"/>

    <import file="${targets-dir}/validate.xml"/>
    <import file="${targets-dir}/webapp.xml"/>
    <import file="${targets-dir}/war.xml"/>
    <import file="${targets-dir}/site.xml"/>

Where:

   src/core/targets webapp.xml war.xml validate.xml site.xml
     ^^^^^^^^

IIRC in this case the build would automatically copy them over.

-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------


Mime
View raw message