Return-Path: 
 <forrest-dev-return-8520-apmail-xml-forrest-dev-archive=xml.apache.org@xml.apache.org>
Delivered-To: apmail-xml-forrest-dev-archive@www.apache.org
Received: (qmail 42064 invoked from network); 28 Dec 2003 23:11:33 -0000
Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12)
  by minotaur-2.apache.org with SMTP; 28 Dec 2003 23:11:33 -0000
Received: (qmail 82984 invoked by uid 500); 28 Dec 2003 23:11:18 -0000
Delivered-To: apmail-xml-forrest-dev-archive@xml.apache.org
Received: (qmail 82946 invoked by uid 500); 28 Dec 2003 23:11:18 -0000
Mailing-List: contact forrest-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:forrest-dev-help@xml.apache.org>
list-unsubscribe: <mailto:forrest-dev-unsubscribe@xml.apache.org>
list-post: <mailto:forrest-dev@xml.apache.org>
Reply-To: forrest-dev@xml.apache.org
Delivered-To: mailing list forrest-dev@xml.apache.org
Received: (qmail 82917 invoked from network); 28 Dec 2003 23:11:17 -0000
Received: from unknown (HELO main.gmane.org) (80.91.224.249)
  by daedalus.apache.org with SMTP; 28 Dec 2003 23:11:17 -0000
Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1Aak4C-0007mI-00
	for <forrest-dev@xml.apache.org>; Mon, 29 Dec 2003 00:11:24 +0100
X-Injected-Via-Gmane: http://gmane.org/
To: forrest-dev@xml.apache.org
Received: from sea.gmane.org ([80.91.224.252])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 1Aak4B-0007m9-00
	for <gmane-text-xml-forrest-devel@m.gmane.org>;
 Mon, 29 Dec 2003 00:11:23 +0100
Received: from news by sea.gmane.org with local (Exim 3.35 #1 (Debian))
	id 1Aak4A-0001Qb-00
	for <gmane-text-xml-forrest-devel@m.gmane.org>;
 Mon, 29 Dec 2003 00:11:22 +0100
From: Nicola Ken Barozzi <nicolaken@apache.org>
Subject: Subtabs in CVS - comments and suggestions
Date: Mon, 29 Dec 2003 00:08:03 +0100
Lines: 32
Message-ID: <bsnnuq$575$1@sea.gmane.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Complaints-To: usenet@sea.gmane.org
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
 rv:1.6b) Gecko/20031205 Thunderbird/0.4
X-Accept-Language: en-us, en
Sender: news <news@sea.gmane.org>
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N


I have committed Ross's subtab patch to CVS with some style mods.

It works on krysalis-site and tigris-style skins for now (but doesn't 
break the other ones).

Some comments:

1 - the 'selected' subtab doesn't seem to be recognized: what did I
     do wrong?

2 - Probably (and contrary to my original suggestion) the DTD is best 
like this

      <tabs>
       <tab>
        <subtab>

In fact ATM since a tab can contain a tab, I have to use (tab)*, which 
does not block nesting levels, while we want a single sublevel

3 - I'd thus change the style name of second level tabs to 'subtab'

4 - still need to patch the docs and forrest-site

Other than that, it's cool :-)

-- 
Nicola Ken Barozzi                   nicolaken@apache.org
             - verba volant, scripta manent -
    (discussions get forgotten, just code remains)
---------------------------------------------------------------------