forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vadim Gritsenko <>
Subject Re: [PATCH] to the book2menu in forrest skin
Date Fri, 12 Sep 2003 00:05:06 GMT
David Crossley wrote:
> Vadim Gritsenko wrote:
> <snip/>
>>But what really should be done in addition to the patch I sent is to 
>>apply this patch to the other skins, as they have similar problem.
> Okay, done now. 
> Before adding this patch to the other skins i did some testing.
> It seemed that this is already handled properly (because it is
> already present in common/...book2menu.xsl). The hidden menu-items
> were correctly not shown. However, on further investigation i saw
> that some dags were left on the krysalis skin ... there was a little
> triangle symbol where the menu-item used to be. Adding the special
> match for type=hidden to the actual skin fixed it.
> So i am confused, but it works.

You shouldn't be :)

<xsl:template match="menu-item"/> from the skin xslt file overrides the 
<xsl:template match="menu-item[@hidden]"/> from the imported stylesheet. 
That's why you have to add this <xsl:template 
match="menu-item[@hidden]"/> again to the skin xslt. Otherwise, it 
produces empty <li/> elements which appear as these little symbols.

PS I made it change actually for the xindice website. Note how download 
link has been implemented:


View raw message