forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Juan Jose Pablos <che...@che-che.com>
Subject Re: [PATCH] to the book2menu in forrest skin
Date Wed, 10 Sep 2003 01:40:01 GMT
Vadim

There is not need to add a new attribute called type if a menu-itme is 
hidden when there is not label.

This is the actual behavior that I found when I was looking at this 
issue, what I would like you to do is to test if this suit your needs.

Can you remove a couple of labels from a site.xml and see if that works 
for you?

Cheers,
cheche



Vadim Gritsenko wrote:
> Juan Jose Pablos wrote:
> 
>> David,
>>
>>> Well i was adding Vadim's patch to handle the old book.xml menus.
>>> I tested it using Cocoon's docs and everything worked fine.
>>>
>>> --David
>>>
>>
>> So we need to go use same way for both, what do you thin if we do a:
>>
>> <xsl:template match="menu-item[@label]"/>
> 
> 
> Why would you do that? There is already template <xsl:template 
> match="menu-item"/> which will cover all normal usage scenarios.
> 
> <xsl:template match="menu-item[@type='hidden']"/> is required to ignore 
> hidden links which previous stylesheet failed to do.
> 
> 
> But what really should be done in addition to the patch I sent is to 
> apply this patch to the other skins, as they have similar problem.
> 
> Vadim
> 



Mime
View raw message