Return-Path: 
 <forrest-dev-return-3262-apmail-xml-forrest-dev-archive=xml.apache.org@xml.apache.org>
Delivered-To: apmail-xml-forrest-dev-archive@xml.apache.org
Received: (qmail 87059 invoked by uid 500); 8 Nov 2002 04:34:30 -0000
Mailing-List: contact forrest-dev-help@xml.apache.org; run by ezmlm
Precedence: bulk
list-help: <mailto:forrest-dev-help@xml.apache.org>
list-unsubscribe: <mailto:forrest-dev-unsubscribe@xml.apache.org>
list-post: <mailto:forrest-dev@xml.apache.org>
Reply-To: forrest-dev@xml.apache.org
Delivered-To: mailing list forrest-dev@xml.apache.org
Received: (qmail 87046 invoked from network); 8 Nov 2002 04:34:28 -0000
Received: from ptolemy.goulburn.net.au (203.28.11.5)
  by daedalus.apache.org with SMTP; 8 Nov 2002 04:34:28 -0000
Received: (qmail 2933 invoked from network); 8 Nov 2002 04:34:36 -0000
Received: from max-02-010.goulburn.net.au (203.28.11.199)
  by ptolemy.goulburn.net.au with SMTP; 8 Nov 2002 04:34:36 -0000
Subject: Re: Skin validation
From: David Crossley <crossley@indexgeo.com.au>
To: forrest-dev@xml.apache.org
In-Reply-To: <20021108040720.GB3696@expresso.localdomain>
References: <3DCAF7D3.1010509@wkwyw.net>
	<200211081045.45906.peter@apache.org>
	<20021108024658.GD3007@expresso.localdomain>
	<1036725329.12715.266.camel@ighp>
	<20021108033308.GA3696@expresso.localdomain>
	<1036727650.12715.375.camel@ighp>
	<20021108040720.GB3696@expresso.localdomain>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
X-Mailer: Ximian Evolution 1.0.3 (1.0.3-6) 
Date: 08 Nov 2002 15:34:34 +1100
Message-Id: <1036730076.12714.520.camel@ighp>
Mime-Version: 1.0
X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N

Jeff Turner wrote:
> David Crossley wrote:
<snip/>

> > Ah i see. I am not using a project-specific skin.
> > 
> > I was wanting it to do validation of the main
> > forrest-site skin, etc. both during 'build.sh docs'
> > and the 'forrest' build ... i was trying some mods to
> > the "forrest-site" and "basic" skins.
> > 
> > I will keep looking. It must be a strange setting of
> > the forrest.validate.* properties.
> 
> Oh.. no, it deliberately doesn't validate those, on the assumption that
> Forrest wouldn't distribute broken stylesheets, and having every user
> validate them would slow things down.  If you think it's a good idea, we
> can add a forrest.validate.internal.skins (or something) property.

I was wondering if that might be the issue.
Yes, i think that it is vitally important to validate
the "internal" skins, as well as all config files,
and xdocs, and sitemaps, and stuff. Otherwise how do
we *know* that we are not distributing broken stuff.

I presumed that during "build docs" Forrest is treating
itself as yet another project. So i presumed that it would
therefore validate its own stuff (the targets do get called).
I now gather that this is not so.

Yes, i agree that every user should not need to do this
every time. However, if they are working on core Forrest
stuff (i.e. a developer) then we want them to validate
before sending patches.

Should i add a general validation target into the top-level
xml-forrest/build.xml that does various validation of
Forrest's core stylesheets and config files? It may better
belong at that level - forrest-shbat/forrest.build.xml
is getting quite full.

--David