forrest-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Turner <je...@apache.org>
Subject Re: Newbie Feedback
Date Mon, 04 Nov 2002 07:39:38 GMT
On Mon, Nov 04, 2002 at 10:15:49AM +1100, Peter Donald wrote:
> One more thing I didn't like was the way the skinconf was defined. The first 
> thing I did was change
> 
> <trail>
>   <link1 name="RealityForge" href="http://www.realityforge.org/"/>
>   <link2 name="ThinkTank" href="http://www.realityforge.org/thinktank"/>
> </trail>
> 
> to
> 
> <trail>
>   <link name="RealityForge" href="http://www.realityforge.org/"/>
>   <link name="ThinkTank" href="http://www.realityforge.org/thinktank"/>
> </trail>

IIRC, the reason for link1, link2 etc was that <xmlproperty> needs
uniquely named elements.  We use <xmlproperty> to convert the link hrefs
to @skin.blah@ tokens.

Since we need Ant 1.6 for XML validation anyway, probably we could use
${jxpath:...} syntax instead of <xmlproperty>.

> I was also consider changing all the image/icon defs to use a standard format 
> but have a "role" element that could define their role. ie Look something 
> like
> 
> <logo>
>   <name>ThinkTank</name>
>   <role>project</role>
>   <url>http://www.realityforge.org/thinktank</url>
>   <image>skin/images/thinktank-logo.gif</image>
>   <width>88</width>
>   <height>31</height>
> </logo>
> <logo>
>   <name>RealityForge</name>
>   <role>group</role>
>   <url>http://www.realityforge.org/</url>
>   <image>skin/images/rf.gif</image>
>   <width>88</width>
>   <height>31</height>
> </logo>
> <logo>
>   <name>Built with Cocoon</name>
>   <role>credit</role>
>   <url>http://xml.apache.org/cocoon/</url>
>   <image>skin/images/built-with-cocoon.gif</image>
>   <width>88</width>
>   <height>31</height>
> </logo>

Sounds good.

--Jeff

> Thoughts?
> 
> -- 
> Cheers,
> 
> Peter Donald
> *------------------------------------------------*
> | You can't wake a person who is pretending      |
> |       to be asleep. -Navajo Proverb.           |
> *------------------------------------------------* 
> 
> 

Mime
View raw message