fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] keith-turner commented on a change in pull request #1018: Scan command now can produce results as csv and json. Related to #984
Date Thu, 01 Jan 1970 00:00:00 GMT
keith-turner commented on a change in pull request #1018: Scan command now can produce results
as csv and json. Related to #984
URL: https://github.com/apache/fluo/pull/1018#discussion_r169797950
 
 

 ##########
 File path: modules/api/src/main/java/org/apache/fluo/api/config/FluoConfiguration.java
 ##########
 @@ -935,6 +938,18 @@ public SimpleConfiguration getAppConfiguration() {
     return subset(APP_PREFIX);
   }
 
+  /**
+   * @return A subset of this configuration using the prefix {@value #SCAN_PREFIX}. Any change
made
+   *         to subset will be reflected in this configuration, but with the prefix added.
This
+   *         method is useful for setting application configuration before initialization.
For
+   *         reading application configuration after initialization, see
+   *         {@link FluoClient#getAppConfiguration()} and {@link Context#getAppConfiguration()}
+   * @since 1.2
+   */
+  public SimpleConfiguration getScanConfiguration() {
 
 Review comment:
   It occurred to me that the scan command is not part of Fluo's java API.   The scan command
is outside of the Java API.  These configuration are related to Fluo's java API.  Based on
this, I am thinking we should only have the command line options and not these configuration
options.
   
   It should be possible to use Fluo only via the Java API without ever using the Fluo tarball.
 In this case, this scan configuration is out of place and confusing.
   
   Is there a use case for having these config options that the command line options can not
satisfy?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message