fluo-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikewalch <...@git.apache.org>
Subject [GitHub] incubator-fluo pull request #817: fixes #816 introduced better way to setup ...
Date Mon, 20 Mar 2017 20:02:25 GMT
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/incubator-fluo/pull/817#discussion_r106992697
  
    --- Diff: modules/api/src/main/java/org/apache/fluo/api/observer/Observer.java ---
    @@ -17,17 +17,19 @@
     
     import org.apache.fluo.api.client.FluoClient;
     import org.apache.fluo.api.client.TransactionBase;
    +import org.apache.fluo.api.config.FluoConfiguration;
     import org.apache.fluo.api.config.SimpleConfiguration;
     import org.apache.fluo.api.data.Bytes;
     import org.apache.fluo.api.data.Column;
     import org.apache.fluo.api.metrics.MetricsReporter;
     
     /**
      * Implemented by users to a watch a {@link Column} and be notified of changes to the
Column via the
    - * {@link #process(TransactionBase, Bytes, Column)} method. An observer is created for
each worker
    - * thread and reused for the lifetime of a worker thread. Consider extending
    - * {@link AbstractObserver} as it will let you optionally implement {@link #init(Context)}
and
    - * {@link #close()}. The abstract class will also shield you from the addition of interface
methods.
    + * {@link #process(TransactionBase, Bytes, Column)} method.
    + * 
    + * <p>
    + * In Fluo version 1.1.0 this was converted to a functional interface. This change along
with the
    --- End diff --
    
    Could add `@FunctionalInterface` annotation to class


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message