fluo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kenneth McFarland <glorifiedcalcula...@gmail.com>
Subject Re: Request review
Date Wed, 31 Jul 2019 18:41:40 GMT
Let me know if that LGTM works, not sure how to review a pushed commit.

On Wed, Jul 31, 2019, 11:19 AM Kenneth McFarland <
glorifiedcalculator@gmail.com> wrote:

> If you can give me approx 1 1/2 hours I'll rev so don't worry about doing
> a pull.
>
> On Wed, Jul 31, 2019, 11:17 AM Kenneth McFarland <
> glorifiedcalculator@gmail.com> wrote:
>
>> I've done it, remember? I'll review real quick.
>>
>> On Wed, Jul 31, 2019, 11:16 AM Christopher <ctubbsii@apache.org> wrote:
>>
>>> Hi folks, once again, I forgot that Fluo was RTC, not CTR, and I
>>> unintentionally pushed a trivial commit to fluo-uno without prior
>>> review.
>>>
>>> So, once again, I'm attempting to remedy the mistake after the fact
>>> (forgiveness appreciated, but optional).
>>>
>>> If somebody could review
>>>
>>> https://github.com/apache/fluo-uno/commit/59ce5c548c0e4a2c0fab2e14952355d674e90705
>>> I would greatly appreciate it. If no review occurs today, I will
>>> revert, and put up a pull request for review, as I should have done
>>> initially.
>>>
>>> Thanks,
>>>
>>> Christopher
>>>
>>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message