fluo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kenneth mcfarland <kennethpmcfarl...@gmail.com>
Subject Re: [GitHub] ctubbsii commented on a change in pull request #1043: FLUO-1002 Create integration test for `FluoAdmin.remove()`
Date Wed, 20 Jun 2018 21:04:50 GMT
I just might do that. The errors they throw "instance must be started.."
are imo terrible, it's used for every method leaving one to wonder what
method was called.

On Wed, Jun 20, 2018, 2:02 PM GitBox <git@apache.org> wrote:

> ctubbsii commented on a change in pull request #1043: FLUO-1002 Create
> integration test for `FluoAdmin.remove()`
> URL: https://github.com/apache/fluo/pull/1043#discussion_r196941464
>
>
>
>  ##########
>  File path:
> modules/core/src/main/java/org/apache/fluo/core/util/CuratorUtil.java
>  ##########
>  @@ -116,6 +116,14 @@ public static CuratorFramework newCurator(String
> zookeepers, int timeout, String
>      }
>    }
>
> +  public static boolean pathExist(CuratorFramework curator, String zPath)
> {
> +    try {
> +      return curator.checkExists().forPath(zPath) != null;
> +    } catch (Exception e) {
>
>  Review comment:
>    If Curator is throwing "Exception", then there's not much we can do,
> except suggest a patch to Curator.
>
> ----------------------------------------------------------------
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on GitHub and use the
> URL above to go to the specific comment.
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
> With regards,
> Apache Git Services
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message