fluo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Keith Turner <ke...@deenlo.com>
Subject Re: #991 format source
Date Thu, 18 Jan 2018 21:09:39 GMT
On Thu, Jan 18, 2018 at 2:00 AM, Kenneth Mcfarland
<kennethmcfarland@apache.org> wrote:
> This is a kind reminder to all devs pls run mvn verify to ensure the
> patches are formatted.

Ideally the travis build would fail if it formatted code.  This may be
possible if there is a maven plugin that checks if any git tracked
files were changed.

>
> When you run mvn verify it will format all of the source code which will
> create changes.
>
> If you commit and then run mvn verify and it formats something then you
> have another commit to issue. IMHO It is best to run mvn verify and then if
> everything passes issue a commit, or squash, or whatever works for you.
>
> Happy coding!

Mime
View raw message