fluo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Keith Turner <ke...@deenlo.com>
Subject Re: [GitHub] keith-turner commented on a change in pull request #951: FLUO-950 Make VisibilityCache customizable
Date Mon, 23 Oct 2017 16:10:33 GMT
On Mon, Oct 23, 2017 at 11:38 AM, kenneth mcfarland
<kennethpmcfarland@gmail.com> wrote:
> Ok @keith-turner happy to do so. I can make these changes this afternoon
> and then can I claim 939?

Sure, I have no objections to you working on 939.

>
> On Oct 23, 2017 8:35 AM, "GitBox" <git@apache.org> wrote:
>
>> keith-turner commented on a change in pull request #951: FLUO-950 Make
>> VisibilityCache customizable
>> URL: https://github.com/apache/fluo/pull/951#discussion_r146304645
>>
>>
>>
>>  ##########
>>  File path: modules/core/src/main/java/org/apache/fluo/core/impl/
>> FluoConfigurationImpl.java
>>  ##########
>>  @@ -143,6 +143,45 @@ public static long getTxIfoCacheTimeout(FluoConfiguration
>> conf, TimeUnit tu) {
>>      }
>>      return tu.convert(millis, TimeUnit.MILLISECONDS);
>>    }
>> +  public static final String VISIBILITY_CACHE_SIZE = FLUO_IMPL_PREFIX +
>> ".visibility.cache.size.mb";
>> +  public static final long VISIBILITY_CACHE_SIZE_DEFAULT = 10000000;
>>
>>  Review comment:
>>    I think in java 7 or 8 the ability to add underscores in numbers was
>> added.  So could change this to `10_000_000` to make it a bit more readable.
>>
>> ----------------------------------------------------------------
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on GitHub and use the
>> URL above to go to the specific comment.
>>
>> For queries about this service, please contact Infrastructure at:
>> users@infra.apache.org
>>
>>
>> With regards,
>> Apache Git Services
>>

Mime
View raw message