fluo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From kenneth mcfarland <kennethpmcfarl...@gmail.com>
Subject Re: [GitHub] keith-turner commented on a change in pull request #963: Fix for FLUO-793 Modify ITs to use JUnits timeout rule
Date Mon, 30 Oct 2017 20:05:06 GMT
I always try to respond as soon as possible to you guys please forgive
typos they we're caused by using text to talk.

I will follow up and make those changes tonight if not earlier. Thank you
for helping me.

On Oct 30, 2017 10:51 AM, "kenneth mcfarland" <kennethpmcfarland@gmail.com>
wrote:

> Yep that was the timeout one with 120 second rule. I'll handle that case
> of the bit shifting when I get out of class and then I'll do what I can do
> about the Jade unit timeout rule 2 thank you
>
> On Oct 30, 2017 9:41 AM, "GitBox" <git@apache.org> wrote:
>
>> keith-turner commented on a change in pull request #963: Fix for FLUO-793
>> Modify ITs to use JUnits timeout rule
>> URL: https://github.com/apache/fluo/pull/963#discussion_r147761865
>>
>>
>>
>>  ##########
>>  File path: modules/integration/src/test/java/org/apache/fluo/integratio
>> n/impl/GarbageCollectionIteratorIT.java
>>  ##########
>>  @@ -54,7 +58,7 @@ private void waitForGcTime(long expectedTime) throws
>> Exception {
>>      }
>>    }
>>
>> -  @Test(timeout = 60000)
>>
>>  Review comment:
>>    Nice
>>
>> ----------------------------------------------------------------
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on GitHub and use the
>> URL above to go to the specific comment.
>>
>> For queries about this service, please contact Infrastructure at:
>> users@infra.apache.org
>>
>>
>> With regards,
>> Apache Git Services
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message