fluo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christopher <ctubb...@apache.org>
Subject Re: [VOTE] Fluo 1.0.0-incubating-rc1
Date Fri, 23 Sep 2016 21:57:19 GMT
Technically, this vote doesn't expire until 1930EDT, but I don't plan on
voting on this one, and it doesn't look like it'll pass as-is. I'll create
an RC2 on Monday, if this vote fails.

On Fri, Sep 23, 2016 at 5:35 PM Keith Turner <keith@deenlo.com> wrote:

> On Wed, Sep 21, 2016 at 11:13 PM, Josh Elser <elserj@apache.org> wrote:
> > +1 (binding)
> >
> > First off, interesting use of the fetch.sh script to circumvent any extra
> > licensing in Fluo. I feel like this kind of goes against the intent of
> the
> > LICENSE and NOTICE files (they're meant to be there so that users know
> your
> > product depends on and those licenses), but I can't cite a reason why
> it's
> > against policy.
> >
> > * xsum/sigs OK
> > * no binary files in source-release
> > * apache-rat:check passes
> > * mvn verify passes (sans GarbageCollectionIteratorIT[1])
> > * DISCLAIMER is present
> > * L&N are fine
> > * KEYS present and contains the signing key
> > * SHA1 present in repo
> >
> > * I feel like you could easily add the license header to the
> docs/**/*.md,
> > but I know I've seen this go both ways.
>
> Just made this change
>
> > * I would like to see apache-fluo in the tarball names and directories
> > contained in the tarballs, but I've also argued at length with
> Christopher
> > about this in the past. I will probably continue to cite it as something
> I'd
> > like to see :)
> > * I would guess some people in IPMC would like to see your artifacats
> staged
> > to dist.a.o/repos/dist/dev/incubator/fluo but nothing wrong with
> references
> > from repo.a.o AFAIK
> >
> > Made a pass over the website and things look OK too. Will be happy to see
> > the two reference to "pre-ASF life" things removed promptly after
> > 1.0.0-incubating is released.
> >
> >
> > - Josh
> >
> > [1]
> >
> > ```
> > Running org.apache.fluo.integration.impl.GarbageCollectionIteratorIT
> > Tests run: 4, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 113.007
> sec
> > <<< FAILURE! - in
> > org.apache.fluo.integration.impl.GarbageCollectionIteratorIT
> >
> testGetOldestTimestamp(org.apache.fluo.integration.impl.GarbageCollectionIteratorIT)
> > Time elapsed: 21.67 sec  <<< FAILURE!
> > java.lang.AssertionError: expected:<0> but was:<2>
> >         at
> >
> org.apache.fluo.integration.impl.GarbageCollectionIteratorIT.testGetOldestTimestamp(GarbageCollectionIteratorIT.java:194)
> > ```
> >
> > Christopher wrote:
> >>
> >> Fluo Developers,
> >>
> >> Please consider the following candidate for Fluo 1.0.0-incubating.
> >>
> >> Git Commit:
> >>      b07fbf8b755e8f555d06fe2d57db2868f9b20c1c
> >> Branch:
> >>      1.0.0-incubating-rc1
> >>
> >> If this vote passes, a gpg-signed tag will be created using:
> >>      git tag -f -m 'Apache Fluo 1.0.0-incubating' -s
> >> rel/fluo-1.0.0-incubating \
> >>      b07fbf8b755e8f555d06fe2d57db2868f9b20c1c
> >>
> >> Staging repo:
> >> https://repository.apache.org/content/repositories/orgapachefluo-1012
> >> Source (official release artifact):
> >>
> >>
> https://repository.apache.org/content/repositories/orgapachefluo-1012/org/apache/fluo/fluo/1.0.0-incubating/fluo-1.0.0-incubating-source-release.tar.gz
> >> Binary:
> >>
> >>
> https://repository.apache.org/content/repositories/orgapachefluo-1012/org/apache/fluo/fluo/1.0.0-incubating/fluo-1.0.0-incubating-bin.tar.gz
> >> (Append ".sha1", ".md5", or ".asc" to download the signature/hash for a
> >> given artifact.)
> >>
> >> All artifacts were built and staged with:
> >>      mvn release:prepare&&  mvn release:perform
> >>
> >> Signing keys are available at
> >> https://www.apache.org/dist/incubator/fluo/KEYS
> >> (Expected fingerprint: 8CC4F8A2B29C2B040F2B835D6F0CDAE700B6899D)
> >>
> >> Release notes (in progress) can be found at:
> >> https://fluo.apache.org/.../1.0.0-incubating
> >>
> >> Please vote one of:
> >> [ ] +1 - I have verified and accept...
> >> [ ] +0 - I have reservations, but not strong enough to vote against...
> >> [ ] -1 - Because..., I do not accept...
> >> ... these artifacts as the 1.0.0-incubating release of Apache Fluo.
> >>
> >> This vote will end on Fri Sep 23 23:30:00 UTC 2016
> >> (Fri Sep 23 19:30:00 EDT 2016 / Fri Sep 23 16:30:00 PDT 2016)
> >>
> >> Thanks!
> >>
> >> P.S. Hint: download the whole staging repo with
> >>      wget -erobots=off -r -l inf -np -nH \
> >>
> >> https://repository.apache.org/content/repositories/orgapachefluo-1012/
> >>      # note the trailing slash is needed
> >>
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message