fluo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Josh Elser <els...@apache.org>
Subject Re: [VOTE] Apache Fluo Parent POM 1 (rc3) and Build Resources 1.0.0 (rc1)
Date Mon, 08 Aug 2016 01:39:58 GMT
Even so, you have no KEYS file in dev/dist either.

You *must* have this file deployed.

Christopher wrote:
> You're looking in the wrong place. The address is:
> https://dist.apache.org/repos/dist/dev/incubator/fluo (that's dist/dev/,
> not dist/release/)
> Also, that staging location is optional. I only put them there as a matter
> of convenience for those preferring to download from there rather than
> examine them in Nexus, and to make it easy to "release" with a simple "svn
> mv" later.
>
> The names for the tarballs were discussed in a previous thread on the
> incubator list. The names are derived from the artifactId names in their
> Maven coordinates. Modifying the tarballs to diverge from these doesn't
> make sense, because they won't match the actual artifacts in Maven Central,
> and that can cause a lot of confusion when users try to find the correct
> artifact for dependency resolution. Further, adding "apache-" as a prefix
> is redundant in the Maven coordinates because the groupId is
> org.apache.fluo. The "apache-" prefix is not required, and is not done by
> many Apache projects. Additionally, the build-resources artifact is
> actually just "build-resources" it does not have "fluo" in the name,
> because while the fluo parent POM uses it, and it is produced by the fluo
> team, it does not actually have anything to do with "fluo" software. It
> could be used by any project wishing to depend on the checkstyle/formatter
> rules it contains.
>
> So, yes, we could rename the artifactId so that "apache-" and
> "apache-fluo-" prefix these artifacts... but I think it's not necessary,
> adds redundancy to the maven coordinates, and doesn't actually seem to
> achieve any useful goal. As far as I can tell, the only thing I can tell
> that it actually accomplishes is make the file names ridiculously long.
>
> Also, if we don't do that this time, but rename the artifacts later, then
> we have the situation where you can't just update the version number to
> update to the next version... users actually have to start changing which
> artifact they are dependent on.
>
> On Sun, Aug 7, 2016 at 9:12 PM Josh Elser<elserj@apache.org>  wrote:
>
>> -1
>>
>> I do not see a published KEYS file for Fluo at
>> https://dist.apache.org/repos/dist/release/incubator/fluo (you don't
>> have the staging directory at all, actually). I am happy to switch this
>> to +1 after this file is made (VOTE doesn't need to fail).
>>
>> The good:
>>
>> * sigs/xsums match
>> * DISCLAIMER is present
>> * Files have correct license headers
>> * LICENSE and NOTICE are correct
>>
>> The "please fix for next time":
>>
>> Can you please make sure that the release artifacts start with the
>> official project name next time? e.g.
>>
>> apache-fluo-build-resources-1.0.0-incubating-source-release.tar.gz
>> apache-fluo-parent-1-incubating-source-release.tar.gz
>>
>> I assume this is easy to do (at least I know other projects have that
>> figured out).
>>
>> Christopher wrote:
>>> Fluo Developers,
>>>
>>> I'm combining these two votes, because they are a bit interdependent, and
>>> both are small.
>>>
>>> Please consider the following candidates for Fluo Parent POM 1-incubating
>>> and Fluo Build Resources 1.0.0-incubating.
>>>
>>> Git Commits/branches:
>>>       02d4ea2332598a94285985ee8a1c8e92a42b4770 (build-resources-1.0.0-rc1)
>>>       95c48e3f14faf5cdca259d8ec60ec68b640fce1e (fluo-parent-1-rc3)
>>>
>>> If this vote passes, a vote will be brought to the IPMC, and if that
>>> passes, gpg-signed tags will be created using:
>>>       git tag -f -m 'Apache Fluo Build Resources 1.0.0-incubating' -s
>>> rel/build-resources-1.0.0-incubating
>>> 02d4ea2332598a94285985ee8a1c8e92a42b4770
>>>       git tag -f -m 'Apache Fluo Parent POM 1-incubating' -s
>>> rel/fluo-parent-1-incubating 95c48e3f14faf5cdca259d8ec60ec68b640fce1e
>>>
>>> Staging repo:
>>> https://repository.apache.org/content/repositories/orgapachefluo-1004
>>>
>>> Source artifacts:
>>>
>> https://repository.apache.org/content/repositories/orgapachefluo-1004/org/apache/fluo/build-resources/1.0.0-incubating/build-resources-1.0.0-incubating-source-release.tar.gz
>> https://repository.apache.org/content/repositories/orgapachefluo-1004/org/apache/fluo/fluo-parent/1-incubating/fluo-parent-1-incubating-source-release.tar.gz
>>> (Append ".sha1", ".md5", or ".asc" to download the signature/hash for a
>>> given artifact.)
>>>
>>> Signing key fingerprint is: 8CC4F8A2B29C2B040F2B835D6F0CDAE700B6899D
>>>
>>> Please vote one of:
>>> [ ] +1 - I have verified and accept...
>>> [ ] +0 - I have reservations, but not strong enough to vote against...
>>> [ ] -1 - Because..., I do not accept...
>>> ... these artifacts as the 1-incubating release of Apache Fluo Parent
>> POM.
>>> This vote will end on Sun Aug 07 21:00:00 UTC 2016
>>> (Sun Aug 07 17:00:00 EDT 2016 / Sun Aug 07 14:00:00 PDT 2016)
>>>
>>> Thanks!
>>>
>>> P.S. Hint: download the whole staging repo with
>>>       wget -erobots=off -r -l inf -np -nH \
>>>
>> https://repository.apache.org/content/repositories/orgapachefluo-1004/
>>>       # note the trailing slash is needed
>>>
>

Mime
View raw message