fluo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubb...@apache.org
Subject [fluo] branch build-resources updated: Add Accumulo API checks to checkstyle rules (#905)
Date Tue, 15 Aug 2017 22:37:21 GMT
This is an automated email from the ASF dual-hosted git repository.

ctubbsii pushed a commit to branch build-resources
in repository https://gitbox.apache.org/repos/asf/fluo.git


The following commit(s) were added to refs/heads/build-resources by this push:
     new cd362ec  Add Accumulo API checks to checkstyle rules (#905)
cd362ec is described below

commit cd362ec321787d909addefb3b77336c109b92145
Author: Christopher Tubbs <ctubbsii@apache.org>
AuthorDate: Wed Aug 16 00:37:19 2017 +0200

    Add Accumulo API checks to checkstyle rules (#905)
    
    Prevent use of non-public Accumulo APIs being imported into Fluo
    classes. This removes the need to have a separate execution of
    checkstyle to do Accumulo API checks in Fluo projects.
---
 src/main/resources/org/apache/fluo/resources/java-checkstyle.xml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/main/resources/org/apache/fluo/resources/java-checkstyle.xml b/src/main/resources/org/apache/fluo/resources/java-checkstyle.xml
index f291740..24a401d 100644
--- a/src/main/resources/org/apache/fluo/resources/java-checkstyle.xml
+++ b/src/main/resources/org/apache/fluo/resources/java-checkstyle.xml
@@ -170,5 +170,11 @@
       <message key="name.invalidPattern" value="Method name ''{0}'' must match pattern
''{1}''."/>
     </module>
     <module name="SingleLineJavadoc"/>
+    <module name="RegexpSinglelineJava">
+      <!--check that only Accumulo public APIs are imported-->
+      <property name="format" value="import\s+org[.]apache[.]accumulo[.](?:.*[.](?:impl|thrift)[.].*|(?!core|minicluster).*|core[.](?!client|data|iterators|security[.]Authorizations|security[.]ColumnVisibility|util[.]format[.]Formatter).*|core[.]data[.](?!Key|Mutation|Value|Range|Condition|ConditionalMutation|ByteSequence|PartialKey|ColumnUpdate|ArrayByteSequence).*)"
/>
+      <property name="ignoreComments" value="true" />
+      <property name="message" value="Accumulo non-public classes imported" />
+    </module>
   </module>
 </module>

-- 
To stop receiving notification emails like this one, please contact
['"commits@fluo.apache.org" <commits@fluo.apache.org>'].

Mime
View raw message