fluo-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubb...@apache.org
Subject [3/5] incubator-fluo git commit: Fixes #732 Remove declaration of unthrown exceptions
Date Wed, 27 Jul 2016 20:03:22 GMT
Fixes #732 Remove declaration of unthrown exceptions

Remove declaration of "throws Exception" from AutoCloseable classes
whose close methods do not actually throw any checked exceptions. This
prevents propagating misinformation about what is possible to occur in
this method, and avoids a compiler warning about the possibility of
throwing InterruptedException.


Project: http://git-wip-us.apache.org/repos/asf/incubator-fluo/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-fluo/commit/302582b7
Tree: http://git-wip-us.apache.org/repos/asf/incubator-fluo/tree/302582b7
Diff: http://git-wip-us.apache.org/repos/asf/incubator-fluo/diff/302582b7

Branch: refs/heads/master
Commit: 302582b74cf967bc47a8262b1d1416e661a66aa4
Parents: eb8a1bc
Author: Christopher Tubbs <ctubbsii@apache.org>
Authored: Tue Jul 26 14:53:31 2016 -0400
Committer: Christopher Tubbs <ctubbsii@apache.org>
Committed: Wed Jul 27 15:54:53 2016 -0400

----------------------------------------------------------------------
 .../main/java/org/apache/fluo/cluster/runner/YarnAppRunner.java    | 2 +-
 .../src/test/java/org/apache/fluo/integration/ITBaseImpl.java      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-fluo/blob/302582b7/modules/cluster/src/main/java/org/apache/fluo/cluster/runner/YarnAppRunner.java
----------------------------------------------------------------------
diff --git a/modules/cluster/src/main/java/org/apache/fluo/cluster/runner/YarnAppRunner.java
b/modules/cluster/src/main/java/org/apache/fluo/cluster/runner/YarnAppRunner.java
index 6c52292..7894bce 100644
--- a/modules/cluster/src/main/java/org/apache/fluo/cluster/runner/YarnAppRunner.java
+++ b/modules/cluster/src/main/java/org/apache/fluo/cluster/runner/YarnAppRunner.java
@@ -434,7 +434,7 @@ public class YarnAppRunner extends ClusterAppRunner implements AutoCloseable
{
   }
 
   @Override
-  public void close() throws Exception {
+  public void close() {
     for (TwillRunnerService twillRunner : twillRunners.values()) {
       twillRunner.stop();
     }

http://git-wip-us.apache.org/repos/asf/incubator-fluo/blob/302582b7/modules/integration/src/test/java/org/apache/fluo/integration/ITBaseImpl.java
----------------------------------------------------------------------
diff --git a/modules/integration/src/test/java/org/apache/fluo/integration/ITBaseImpl.java
b/modules/integration/src/test/java/org/apache/fluo/integration/ITBaseImpl.java
index 14d5efd..656a5d9 100644
--- a/modules/integration/src/test/java/org/apache/fluo/integration/ITBaseImpl.java
+++ b/modules/integration/src/test/java/org/apache/fluo/integration/ITBaseImpl.java
@@ -56,7 +56,7 @@ public class ITBaseImpl extends ITBase {
     }
 
     @Override
-    public void close() throws Exception {
+    public void close() {
       env.close();
     }
   }


Mime
View raw message