flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [flume] AndreLouisCaron commented on a change in pull request #320: Fix issues reported by SpotBugs in ElasticSearch sink
Date Fri, 27 Mar 2020 01:42:16 GMT
AndreLouisCaron commented on a change in pull request #320: Fix issues reported by SpotBugs
in ElasticSearch sink
URL: https://github.com/apache/flume/pull/320#discussion_r398989115
 
 

 ##########
 File path: flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/client/ElasticSearchRestClient.java
 ##########
 @@ -105,7 +105,7 @@ public void addEvent(Event event, IndexNameBuilder indexNameBuilder,
String inde
     parameters.put(INDEX_OPERATION_NAME, indexParameters);
 
     Gson gson = new Gson();
-    synchronized (bulkBuilder) {
 
 Review comment:
   Note to reviewers: SpotBugs was reporting `ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message