Mailing-List: contact dev-help@flume.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flume.apache.org
Content-Type: multipart/alternative;
 boundary="===============4419728336234684884=="
MIME-Version: 1.0
Subject: Re: Review Request 50378: FLUME-2960: Support Wildcards in
 directoryname in TaildirSource
From: qiao wen <315524513@qq.com>
To: eskrm@protonmail.com, qiao wen <315524513@qq.com>,
 Flume <dev@flume.apache.org>,
 =?utf-8?q?Bal=C3=A1zs_Don=C3=A1t_Bessenyei?= <bessbd@apache.org>,
 Attila Simon <sati@cloudera.com>, Denes Arvay <denes@cloudera.com>
Date: Mon, 13 Mar 2017 09:11:20 -0000
Message-ID: <20170313091120.60512.99386@reviews-vm2.apache.org>
Auto-Submitted: auto-generated
Sender: qiao wen <noreply@reviews.apache.org>
References: <20170228134215.19421.20888@reviews.apache.org>
In-Reply-To: <20170228134215.19421.20888@reviews.apache.org>
Reply-To: qiao wen <315524513@qq.com>
archived-at: Mon, 13 Mar 2017 09:11:27 -0000

--===============4419728336234684884==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


> On 二月 28, 2017, 1:42 p.m., Balázs Donát Bessenyei wrote:
> > flume-ng-doc/sphinx/FlumeUserGuide.rst
> > Line 1153 (original), 1155 (patched)
> > <https://reviews.apache.org/r/50378/diff/5/?file=1458425#file1458425line1155>
> >
> >     Is there a way to unify regex vs. glob patterns in the path?
> >     Ie. either glob or regex all the way?

In FLUME-2960_6.patch, unify in regex. Please review the latest code.


- qiao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50378/#review167069
-----------------------------------------------------------


On 三月 13, 2017, 9 a.m., qiao wen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50378/
> -----------------------------------------------------------
> 
> (Updated 三月 13, 2017, 9 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> In our log management project, we wan't to track many log files like this:
> /app/dir1/log.*
> /app/dir2/log.*
> ...
> /app/dirn/log.*
> But TaildirSource can't support wildcards in filegroup directory name. The following config is expected:
> a1.sources.r1.filegroups.fg = /app/*/log.*
> 
> 
> Diffs
> -----
> 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst d863068 
>   flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java 8838320 
>   flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java ad9f720 
>   flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java a107a01 
>   flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java f2347f3 
>   flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirEventReader.java bcfe4bb 
>   flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirMatcher.java c341054 
>   flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java 097ee0b 
> 
> 
> Diff: https://reviews.apache.org/r/50378/diff/6/
> 
> 
> Testing
> -------
> 
> All tests in TestTaildirSource passed.
> 
> 
> Thanks,
> 
> qiao wen
> 
>


--===============4419728336234684884==--