flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From qiao wen <315524...@qq.com>
Subject Re: Review Request 50378: FLUME-2960: Support Wildcards in directoryname in TaildirSource
Date Fri, 03 Mar 2017 15:27:53 GMT


> On 三月 3, 2017, 2:44 p.m., Denes Arvay wrote:
> > First of all thank you for your effort by providing and constantly improving this
patch.
> > I have two comments, both of them were already mentioned before, I just would like
to give them more emphasis:
> > - please think a little bit on the `walkFileTree` optimization by implementing the
`preVisitDirectory` (I'm not 100% sure that it's feasible, though) and also please move the
`dirMatcher` and `fileMatcher` to the enclosing class.
> > - Following the symlinks should be added as well to keep the backward compatibility.
(It's still an open issue from the initial code review rounds)

OK, I will take into account the two issues you mentioned.


- qiao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50378/#review167826
-----------------------------------------------------------


On 七月 30, 2016, 5:33 a.m., qiao wen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50378/
> -----------------------------------------------------------
> 
> (Updated 七月 30, 2016, 5:33 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> In our log management project, we wan't to track many log files like this:
> /app/dir1/log.*
> /app/dir2/log.*
> ...
> /app/dirn/log.*
> But TaildirSource can't support wildcards in filegroup directory name. The following
config is expected:
> a1.sources.r1.filegroups.fg = /app/*/log.*
> 
> 
> Diffs
> -----
> 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 3f08d8b 
>   flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java
ad9f720 
>   flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirMatcher.java
c341054 
>   flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java
097ee0b 
> 
> 
> Diff: https://reviews.apache.org/r/50378/diff/5/
> 
> 
> Testing
> -------
> 
> All tests in TestTaildirSource passed.
> 
> 
> Thanks,
> 
> qiao wen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message