flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLUME-3049) Wrapping the exception into SecurityException in UGIExecutor.execute hides the original one
Date Fri, 27 Jan 2017 10:58:24 GMT

    [ https://issues.apache.org/jira/browse/FLUME-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15842559#comment-15842559
] 

ASF GitHub Bot commented on FLUME-3049:
---------------------------------------

GitHub user adenes opened a pull request:

    https://github.com/apache/flume/pull/106

    FLUME-3049: Remove exception wrapping in UGIExecutor.execute()

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/adenes/flume FLUME-3049

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flume/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #106
    
----
commit a4286afc5eb28cb7d89137a53bfe47c365e5a170
Author: Denes Arvay <denes@cloudera.com>
Date:   2017-01-27T10:43:27Z

    FLUME-3049: Remove exception wrapping in UGIExecutor.execute()

----


> Wrapping the exception into SecurityException in UGIExecutor.execute hides the original
one
> -------------------------------------------------------------------------------------------
>
>                 Key: FLUME-3049
>                 URL: https://issues.apache.org/jira/browse/FLUME-3049
>             Project: Flume
>          Issue Type: Bug
>            Reporter: Denes Arvay
>            Assignee: Denes Arvay
>
> see: https://github.com/apache/flume/blob/trunk/flume-ng-auth/src/main/java/org/apache/flume/auth/UGIExecutor.java#L49
> This has unexpected side effects as the callers try to catch the wrapped exception, for
example in {{BucketWriter.append()}}: https://github.com/apache/flume/blob/trunk/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java#L563
> I don't know the original intend behind this wrapping, [~jrufus] or [~hshreedharan],
do you happen to remember? (You were involved in the original implementation in FLUME-2631)
> Right now I don't see any problem in removing this and letting the original exception
to propagate as the {{org.apache.flume.auth.SecurityException}} doesn't appear anywhere in
the public interface.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message