flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Balázs Donát Bessenyei <bes...@apache.org>
Subject Re: Review Request 53339: FLUME-3020: Improve HDFSEventSink Escape Ingestion by more then 10x by not getting InetAddress on every record
Date Thu, 03 Nov 2016 17:49:51 GMT


> On nov. 3, 2016, 1:58 du, Jeff Holoman wrote:
> > flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java, line
552
> > <https://reviews.apache.org/r/53339/diff/2/?file=1550881#file1550881line552>
> >
> >     nit: can you make this final

Maybe (even) private?


- Balázs Donát


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53339/#review154723
-----------------------------------------------------------


On nov. 1, 2016, 8:16 du, Ted Malaska wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53339/
> -----------------------------------------------------------
> 
> (Updated nov. 1, 2016, 8:16 du)
> 
> 
> Review request for Flume and Jeff Holoman.
> 
> 
> Bugs: FLUME-3020
>     https://issues.apache.org/jira/browse/FLUME-3020
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> If you are use escaping the current code will call InetAddress on every record. Which
will result is a huge impact to performance.
> TotalTime,8403,
> totalEventTakeTime,1498,
> totalWriteTime,1981,
> totalWriterSetupTime,65,
> commitTime,201,
> flushTime,18,
> startTrans,7,
> The rest is all InetAddress
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/formatter/output/BucketPath.java cf0fbb0

> 
> Diff: https://reviews.apache.org/r/53339/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ted Malaska
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message