Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id AC355200BB5 for ; Sun, 23 Oct 2016 01:47:32 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 99F8A160AEF; Sat, 22 Oct 2016 23:47:32 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 8DA7E160AE0 for ; Sun, 23 Oct 2016 01:47:31 +0200 (CEST) Received: (qmail 90918 invoked by uid 500); 22 Oct 2016 23:47:30 -0000 Mailing-List: contact dev-help@flume.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flume.apache.org Delivered-To: mailing list dev@flume.apache.org Received: (qmail 90902 invoked by uid 99); 22 Oct 2016 23:47:30 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 22 Oct 2016 23:47:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 878CD180667 for ; Sat, 22 Oct 2016 23:47:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.479 X-Spam-Level: X-Spam-Status: No, score=0.479 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RCVD_IN_SORBS_SPAM=0.5, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=cloudera-com.20150623.gappssmtp.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id z7VBFepvT0eJ for ; Sat, 22 Oct 2016 23:47:27 +0000 (UTC) Received: from mail-yw0-f171.google.com (mail-yw0-f171.google.com [209.85.161.171]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 4B18B5FAF9 for ; Sat, 22 Oct 2016 23:47:26 +0000 (UTC) Received: by mail-yw0-f171.google.com with SMTP id t193so129853975ywc.2 for ; Sat, 22 Oct 2016 16:47:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudera-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=FGUSAJCs8oweSjzvsrZx+sU3IHQLI7oEqddgMxA8p5M=; b=fyJ3AaS25pKIgHQXjW2KSIcTKmLv23Be9R8ElIIqDDQA8HKdMVFZ8kPiL90YltuMXs FIRdfBBkDU5ACy3XKPD256HQqgqpNcXIv7Z7Rf6r2G973Bxig89uB5mpD1b56Q/j0KOX 3L310/cQ74jnQf7GTfV3sHs/pbivAcCOvHDKK9kuxVr+lPpM8583CNqpKhgrPh0m8Gi7 /B6HCfj1T01ufyKaNLnf17PrXvBw6yZpj680VsylTB87JZzCR3/uMMfvZE6F5Z0jXWrO K6DHybNXcSbKDCuv7awx2L/A6vaqCxX24ldNbMYeOdoo1E2vM87FtLpIaRumm6ePeHjf 3ngA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=FGUSAJCs8oweSjzvsrZx+sU3IHQLI7oEqddgMxA8p5M=; b=Vd0cCUlpIrdXyphpGJcljcnAHCxY/JxK9mhObflma/r9pHdeyhcOpl0PuHDpng8Oe6 OoJxILSrDMk6zIvxSYGLR1OL6PmjiAQT6t6h0waA0ndw1pm7FtkmVlFgCCjf3yDhDiY4 DV/d/tswq3w8IerWJQDGFYtnlVSYymuyVdIjn/HMkWsgVplfGaXqqIj9amJazO7tyqTF I1yQ0xR5FfHe51v57zWVBrdiNigW7RHVO2HdZYydSp0wGx1NkYC7GpuWuw9K8GyCRYr2 4vOia0nXVZO8uCE8i4r9KmK3fK46Jr3/8sia+Are7aCWGzPs+hxgGcf+C/U7HZL7UDce /IvA== X-Gm-Message-State: ABUngvcATcyfn0vewwqFSu25ksH29XLRyYNY0T8l+VoFd0D6gJkVBoIwBsXVr+lDXPzys/O0kkTjIP/YF1o8Ev0/ X-Received: by 10.13.223.70 with SMTP id i67mr9148118ywe.32.1477180045059; Sat, 22 Oct 2016 16:47:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.37.80.14 with HTTP; Sat, 22 Oct 2016 16:47:24 -0700 (PDT) In-Reply-To: References: From: Balazs Donat Bessenyei Date: Sun, 23 Oct 2016 01:47:24 +0200 Message-ID: Subject: Re: Enabling Travis-CI on Flume To: dev@flume.apache.org Content-Type: text/plain; charset=UTF-8 archived-at: Sat, 22 Oct 2016 23:47:32 -0000 Infra has enabled Travis-CI for us. mvn clean install -DskipTests is executed on all PR-s and commits from now on. However, builds occasionally fail with heap space error. To fix that issue, I have opened a pull request: https://github.com/apache/flume/pull/75 . Any reviews and comments are welcome. Thank you, Donat On Fri, Oct 21, 2016 at 6:14 PM, Mike Percy wrote: > Hi Lior! > > No, my message was not directed at you, or any person in particular. I > intended this message for those paying attention to this topic to try and > set expectations for how decision making for things like this usually (and > hopefully) works in Apache: If you are willing to do the work to get > something done, then it will probably get done the way you want! > > (Assuming the end result is something that others in the community want -- > in this case, it's very basic pre-commit checks. I think we have consensus > that pre-commit checks are something that would be a net benefit to > everyone.) > > Sorry for any confusion! And don't let me stop people from voicing their > views and concerns. > > Best, > Mike > > On Fri, Oct 21, 2016 at 4:44 PM, Lior Zeno wrote: > >> Mike, I was not holding Donat back. I was just suggesting ways to configure >> Jenins, per Donat's request. I'm sorry if my former post delivered the >> wrong message. >> >> On Fri, Oct 21, 2016 at 6:29 PM, Mike Percy wrote: >> >> > Personally I prefer Jenkins over TravisCI for various reasons however if >> > Donat is willing to do the work of adding pre-commit checks on PRs via >> > Travis then I say let him do it, in the Apache spirit of "let they that >> do >> > the work make the decisions". >> > >> > If someone actually spends the time to set up Jenkins and configure it to >> > do the same thing, then great, let's switch when it's ready. >> > >> > Note that only ASF committers have access to Jenkins so non-committers >> will >> > need to work with a committer to get it done if they want to help. >> > >> > Mike >> > >> > On Fri, Oct 21, 2016 at 3:46 PM, Lior Zeno wrote: >> > >> > > There are many ways to do it, for example: >> > > https://www.theguild.nl/building-github-pull-requests-using- >> > > jenkins-pipelines/ >> > > or https://www.theguild.nl/building-github-pull-requests-with-jenkins/ >> > for >> > > earlier versions of Jenkins. >> > > I do not really care if it would be Jenkins or Travis, but I do think >> > that >> > > we can get Jenkins configured faster since we already have it. I can >> help >> > > with the configuration. >> > > >> > > On Fri, Oct 21, 2016 at 5:17 PM, Balazs Donat Bessenyei < >> > > bessbd@cloudera.com >> > > > wrote: >> > > >> > > > As I haven't received any objections to enabling Travis, I'm going to >> > > > ask INFRA to enable it for Flume soon. >> > > > >> > > > This change would help submitting and reviewing pull requests. >> > > > >> > > > If someone figures out how we could use Jenkins for this purpose, we >> > > > can always disable Travis. >> > > > >> > > > PS. there are more projects using Travis: >> > > > https://issues.apache.org/jira/browse/INFRA-12757?jql= >> > > > project%20%3D%20INFRA%20AND%20text%20~%20travis%20ORDER% >> > > > 20BY%20updated%20DESC >> > > > >> > > > On Fri, Oct 14, 2016 at 5:41 PM, Attila Simon >> > wrote: >> > > > > Denes I'm happy to help you in this endeavor of setting up jenkins >> > job >> > > > for >> > > > > verifying pull requests. >> > > > > >> > > > > >> > > > > *Attila Simon* >> > > > > Software Engineer >> > > > > Email: sati@cloudera.com >> > > > > >> > > > > [image: Cloudera Inc.] >> > > > > >> > > > > On Fri, Oct 14, 2016 at 2:47 PM, Denes Arvay >> > > wrote: >> > > > > >> > > > >> I'd also vote for Jenkins with github PRs. >> > > > >> I just checked Mesos and the PRs are checked by Travis, or at >> least >> > > they >> > > > >> experienced with it, there's a short discussion regarding to >> Travis >> > at >> > > > >> https://github.com/apache/mesos/pull/165 >> > > > >> >> > > > >> As for the jenkins pull request job I'd be happy to set it up or >> > help >> > > > >> setting it up. >> > > > >> >> > > > >> Denes >> > > > >> >> > > > >> On Fri, Oct 14, 2016 at 2:15 PM Lior Zeno >> > wrote: >> > > > >> >> > > > >> Are we switching to PRs from patches + RB? In Apache Mesos, they >> > have >> > > a >> > > > >> >> > > > >> review bot that can leave a comment on the patch, we could try and >> > > port >> > > > it >> > > > >> >> > > > >> to Flume. I think they use Jenkins too. >> > > > >> >> > > > >> >> > > > >> >> > > > >> On Fri, Oct 14, 2016 at 3:11 PM, Balazs Donat Bessenyei < >> > > > >> bessbd@cloudera.com >> > > > >> >> > > > >> > wrote: >> > > > >> >> > > > >> >> > > > >> >> > > > >> > If the same function can be achieved with Jenkins and it's easy >> > > > >> >> > > > >> > (+quick) to set up, I'm totally happy with that. >> > > > >> >> > > > >> > >> > > > >> >> > > > >> > What do we have to do to enable Jenkins builds on PR-s? >> > > > >> >> > > > >> > >> > > > >> >> > > > >> > On Fri, Oct 14, 2016 at 2:05 PM, Lior Zeno >> > > > wrote: >> > > > >> >> > > > >> > > There are ways to do the same with Jenkins, for instance, see >> > this >> > > > SO >> > > > >> >> > > > >> > > thread >> > > > >> >> > > > >> > > http://stackoverflow.com/questions/37661602/how-to-set- >> > > > >> >> > > > >> > up-a-github-pull-request-build-in-a-jenkinsfile >> > > > >> >> > > > >> > > >> > > > >> >> > > > >> > > On Fri, Oct 14, 2016 at 11:09 AM, Balazs Donat Bessenyei < >> > > > >> >> > > > >> > > bessbd@cloudera.com> wrote: >> > > > >> >> > > > >> > > >> > > > >> >> > > > >> > >> My primary reason for Travis (vs. Jenkins) was that I have >> > > > experience >> > > > >> >> > > > >> > with >> > > > >> >> > > > >> > >> it. >> > > > >> >> > > > >> > >> >> > > > >> >> > > > >> > >> And it leaves these happy little checkmarks: >> > > > >> >> > > > >> > >> https://github.com/sebastianbergmann/phpunit/ >> pull/1051/commits >> > > on >> > > > the >> > > > >> >> > > > >> > >> commits and messages as seen on >> > > > >> >> > > > >> > >> https://github.com/apache/hive/pull/107 . >> > > > >> >> > > > >> > >> >> > > > >> >> > > > >> > >> Jenkins is probably configurable to achieve similar function. >> > > > However, >> > > > >> >> > > > >> > >> I have no idea how to do such. (And could not find an example >> > > when >> > > > I >> > > > >> >> > > > >> > >> did a quick search.) >> > > > >> >> > > > >> > >> >> > > > >> >> > > > >> > >> Are there any disadvantages of enabling Travis on Flume? >> > > > >> >> > > > >> > >> >> > > > >> >> > > > >> > >> >> > > > >> >> > > > >> > >> Thank you, >> > > > >> >> > > > >> > >> >> > > > >> >> > > > >> > >> Donat >> > > > >> >> > > > >> > >> >> > > > >> >> > > > >> > >> On Thu, Oct 13, 2016 at 6:06 PM, Lior Zeno < >> liorzino@gmail.com >> > > >> > > > >> wrote: >> > > > >> >> > > > >> > >> > Jenkins can do PRs as well. If we can upgrade Jenkins to >> 2.0, >> > > we >> > > > >> will >> > > > >> >> > > > >> > be >> > > > >> >> > > > >> > >> > able to define the build step via Jenkinsfile which becomes >> > > very >> > > > >> >> > > > >> > similar >> > > > >> >> > > > >> > >> to >> > > > >> >> > > > >> > >> > Travis. >> > > > >> >> > > > >> > >> > Is there any reason to prefer Travis over Jenkins in our >> > case? >> > > > >> >> > > > >> > >> > >> > > > >> >> > > > >> > >> > On Thu, Oct 13, 2016 at 7:01 PM, Balazs Donat Bessenyei < >> > > > >> >> > > > >> > >> bessbd@cloudera.com >> > > > >> >> > > > >> > >> >> wrote: >> > > > >> >> > > > >> > >> > >> > > > >> >> > > > >> > >> >> Hi All, >> > > > >> >> > > > >> > >> >> >> > > > >> >> > > > >> > >> >> Having something that checks proposed patches (PR-s >> > > especially) >> > > > >> >> > > > >> > >> >> automatically would help a lot with the development on >> > Flume. >> > > > >> >> > > > >> > >> >> >> > > > >> >> > > > >> > >> >> I think, Travis-CI could be an easy solution and (afaik) >> > we'd >> > > > only >> > > > >> >> > > > >> > have >> > > > >> >> > > > >> > >> to >> > > > >> >> > > > >> > >> >> ask infra to enable it for us. >> > > > >> >> > > > >> > >> >> >> > > > >> >> > > > >> > >> >> Please, let me know your thoughts. >> > > > >> >> > > > >> > >> >> >> > > > >> >> > > > >> > >> >> Thank you, >> > > > >> >> > > > >> > >> >> >> > > > >> >> > > > >> > >> >> Donat >> > > > >> >> > > > >> > >> >> >> > > > >> >> > > > >> > >> >> > > > >> >> > > > >> > >> > > > >> >> > > > >> > > >> > >>