Mailing-List: contact dev-help@flume.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flume.apache.org
Content-Type: multipart/alternative;
 boundary="===============6707889490838605058=="
MIME-Version: 1.0
Subject: Re: Review Request 52627: FLUME-2971. Document secure Kafka
 Sink/Source/Channel setup
From: Attila Simon <sati@cloudera.com>
To: Tristan Stevens <tristan@cloudera.com>, Mike Percy <mpercy@apache.org>,
 Attila Simon <sati@cloudera.com>, Flume <dev@flume.apache.org>,
 =?utf-8?q?Bal=C3=A1zs_Don=C3=A1t_Bessenyei?= <bessbd@cloudera.com>
Date: Mon, 10 Oct 2016 18:07:45 -0000
Message-ID: <20161010180745.23091.53754@reviews.apache.org>
Auto-Submitted: auto-generated
Sender: Attila Simon <noreply@reviews.apache.org>
References: <20161010161036.23090.27967@reviews.apache.org>
In-Reply-To: <20161010161036.23090.27967@reviews.apache.org>
Reply-To: Attila Simon <sati@cloudera.com>
archived-at: Mon, 10 Oct 2016 18:07:49 -0000

--===============6707889490838605058==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


> On Oct. 10, 2016, 4:10 p.m., Mike Percy wrote:
> > Nice work! FYI I copied the patched documentation into a GitHub gist for easy reading (v2 of the patch): https://gist.github.com/mpercy/40017fd82cc21af41ddb7cba2b2f4600 since GitHub knows how to render ReStructuredText. Consider posting a gist link to the rendered document for ease of review next time you make large documentation contributions like this.

good idea Mike, will do!


- Attila


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52627/#review151999
-----------------------------------------------------------


On Oct. 10, 2016, 6:04 p.m., Attila Simon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52627/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 6:04 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Bugs: FLUME-2971
>     https://issues.apache.org/jira/browse/FLUME-2971
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> The patch aims to extend the existing documentation of secure Kafka channel with describing SSL+Plaintext setup as well as providing the whole package (SSL+Kerberos+Plain) for KafkaSource and KafkaSink.
> 
> 
> Diffs
> -----
> 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst ab71d38 
> 
> Diff: https://reviews.apache.org/r/52627/diff/
> 
> 
> Testing
> -------
> 
> "mvn site" generated the user guide without an error message in the html. Embedded links are checked not to be broken.
> 
> Known to require attention: Content of the jaas file has to be checked focusing on the requirement of the Client section in every setup.
> 
> 
> Thanks,
> 
> Attila Simon
> 
>


--===============6707889490838605058==--