flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Balazs Donat Bessenyei <bes...@cloudera.com>
Subject Re: Enabling Travis-CI on Flume
Date Fri, 21 Oct 2016 14:17:38 GMT
As I haven't received any objections to enabling Travis, I'm going to
ask INFRA to enable it for Flume soon.

This change would help submitting and reviewing pull requests.

If someone figures out how we could use Jenkins for this purpose, we
can always disable Travis.

PS. there are more projects using Travis:
https://issues.apache.org/jira/browse/INFRA-12757?jql=project%20%3D%20INFRA%20AND%20text%20~%20travis%20ORDER%20BY%20updated%20DESC

On Fri, Oct 14, 2016 at 5:41 PM, Attila Simon <sati@cloudera.com> wrote:
> Denes I'm happy to help you in this endeavor of setting up jenkins job for
> verifying pull requests.
>
>
> *Attila Simon*
> Software Engineer
> Email:   sati@cloudera.com
>
> [image: Cloudera Inc.]
>
> On Fri, Oct 14, 2016 at 2:47 PM, Denes Arvay <denes@cloudera.com> wrote:
>
>> I'd also vote for Jenkins with github PRs.
>> I just checked Mesos and the PRs are checked by Travis, or at least they
>> experienced with it, there's a short discussion regarding to Travis at
>> https://github.com/apache/mesos/pull/165
>>
>> As for the jenkins pull request job I'd be happy to set it up or help
>> setting it up.
>>
>> Denes
>>
>> On Fri, Oct 14, 2016 at 2:15 PM Lior Zeno <liorzino@gmail.com> wrote:
>>
>> Are we switching to PRs from patches + RB? In Apache Mesos, they have a
>>
>> review bot that can leave a comment on the patch, we could try and port it
>>
>> to Flume. I think they use Jenkins too.
>>
>>
>>
>> On Fri, Oct 14, 2016 at 3:11 PM, Balazs Donat Bessenyei <
>> bessbd@cloudera.com
>>
>> > wrote:
>>
>>
>>
>> > If the same function can be achieved with Jenkins and it's easy
>>
>> > (+quick) to set up, I'm totally happy with that.
>>
>> >
>>
>> > What do we have to do to enable Jenkins builds on PR-s?
>>
>> >
>>
>> > On Fri, Oct 14, 2016 at 2:05 PM, Lior Zeno <liorzino@gmail.com> wrote:
>>
>> > > There are ways to do the same with Jenkins, for instance, see this SO
>>
>> > > thread
>>
>> > > http://stackoverflow.com/questions/37661602/how-to-set-
>>
>> > up-a-github-pull-request-build-in-a-jenkinsfile
>>
>> > >
>>
>> > > On Fri, Oct 14, 2016 at 11:09 AM, Balazs Donat Bessenyei <
>>
>> > > bessbd@cloudera.com> wrote:
>>
>> > >
>>
>> > >> My primary reason for Travis (vs. Jenkins) was that I have experience
>>
>> > with
>>
>> > >> it.
>>
>> > >>
>>
>> > >> And it leaves these happy little checkmarks:
>>
>> > >> https://github.com/sebastianbergmann/phpunit/pull/1051/commits on the
>>
>> > >> commits and messages as seen on
>>
>> > >> https://github.com/apache/hive/pull/107 .
>>
>> > >>
>>
>> > >> Jenkins is probably configurable to achieve similar function. However,
>>
>> > >> I have no idea how to do such. (And could not find an example when
I
>>
>> > >> did a quick search.)
>>
>> > >>
>>
>> > >> Are there any disadvantages of enabling Travis on Flume?
>>
>> > >>
>>
>> > >>
>>
>> > >> Thank you,
>>
>> > >>
>>
>> > >> Donat
>>
>> > >>
>>
>> > >> On Thu, Oct 13, 2016 at 6:06 PM, Lior Zeno <liorzino@gmail.com>
>> wrote:
>>
>> > >> > Jenkins can do PRs as well. If we can upgrade Jenkins to 2.0,
we
>> will
>>
>> > be
>>
>> > >> > able to define the build step via Jenkinsfile which becomes very
>>
>> > similar
>>
>> > >> to
>>
>> > >> > Travis.
>>
>> > >> > Is there any reason to prefer Travis over Jenkins in our case?
>>
>> > >> >
>>
>> > >> > On Thu, Oct 13, 2016 at 7:01 PM, Balazs Donat Bessenyei <
>>
>> > >> bessbd@cloudera.com
>>
>> > >> >> wrote:
>>
>> > >> >
>>
>> > >> >> Hi All,
>>
>> > >> >>
>>
>> > >> >> Having something that checks proposed patches (PR-s especially)
>>
>> > >> >> automatically would help a lot with the development on Flume.
>>
>> > >> >>
>>
>> > >> >> I think, Travis-CI could be an easy solution and (afaik) we'd
only
>>
>> > have
>>
>> > >> to
>>
>> > >> >> ask infra to enable it for us.
>>
>> > >> >>
>>
>> > >> >> Please, let me know your thoughts.
>>
>> > >> >>
>>
>> > >> >> Thank you,
>>
>> > >> >>
>>
>> > >> >> Donat
>>
>> > >> >>
>>
>> > >>
>>
>> >
>>

Mime
View raw message