flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Attila Simon <s...@cloudera.com>
Subject Re: Review Request 51802: FLUME-2976: Exception when JMS source tries to connect to a Weblogic server without authentication
Date Thu, 27 Oct 2016 13:38:29 GMT


> On Oct. 27, 2016, 1:37 p.m., Attila Simon wrote:
> > flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java,
line 127
> > <https://reviews.apache.org/r/51802/diff/1/?file=1496685#file1496685line127>
> >
> >     Non breaking change as the password can still be specified as "". (eg by creating
an empty password file with touch and specifying that in flume conf)

So the change itself looks good to me.


- Attila


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51802/#review153276
-----------------------------------------------------------


On Sept. 12, 2016, 1:08 p.m., Denes Arvay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51802/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 1:08 p.m.)
> 
> 
> Review request for Flume, Balázs Donát Bessenyei, Mike Percy, and Attila Simon.
> 
> 
> Bugs: FLUME-2976
>     https://issues.apache.org/jira/browse/FLUME-2976
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> If no `userName` and `passwordFile` is set for the JMS source it sets the password to
`Optional("")`. This leads to an exception in the weblogic jndi context implementation when
trying to connect to a weblogic jms server.
> 
> 
> Diffs
> -----
> 
>   flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/JMSSource.java
7631827 
>   flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestIntegrationActiveMQ.java
53cc09a 
> 
> Diff: https://reviews.apache.org/r/51802/diff/
> 
> 
> Testing
> -------
> 
> - `flume-ng-sources/flume-jms-source` tests pass
> - `TestIntegrationActiveMQ` is now a parameterized test to test with and without authentication.
> 
> 
> Thanks,
> 
> Denes Arvay
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message