flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Denes Arvay (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLUME-2966) NULL text in a TextMessage from a JMS source in Flume can lead to NPE
Date Mon, 26 Sep 2016 07:13:20 GMT

    [ https://issues.apache.org/jira/browse/FLUME-2966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15522304#comment-15522304
] 

Denes Arvay commented on FLUME-2966:
------------------------------------

[~sahuja], thanks for the patch, LGTM, +1

> NULL text in a TextMessage from a JMS source in Flume can lead to NPE
> ---------------------------------------------------------------------
>
>                 Key: FLUME-2966
>                 URL: https://issues.apache.org/jira/browse/FLUME-2966
>             Project: Flume
>          Issue Type: Bug
>    Affects Versions: v1.5.0
>            Reporter: Siddharth Ahuja
>            Assignee: Siddharth Ahuja
>         Attachments: App.java, FLUME-2966-0.patch, FLUME-2966-1.patch
>
>
> Code at https://github.com/apache/flume/blob/trunk/flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/DefaultJMSMessageConverter.java#L103
does not check for a NULL text in a TextMessage from a Flume JMS source. This can lead to
a NullPointerException here: {code}textMessage.getText().getBytes(charset){code} while trying
to de-reference a null text from the textmessage.
> We should probably skip these like the NULL Objects in the ObjectMessage just below at:
https://github.com/apache/flume/blob/trunk/flume-ng-sources/flume-jms-source/src/main/java/org/apache/flume/source/jms/DefaultJMSMessageConverter.java#L107.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message