Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 90CA8200B61 for ; Tue, 9 Aug 2016 14:10:19 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 8F8EF160AA5; Tue, 9 Aug 2016 12:10:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D4F7C160AA4 for ; Tue, 9 Aug 2016 14:10:18 +0200 (CEST) Received: (qmail 78577 invoked by uid 500); 9 Aug 2016 12:10:17 -0000 Mailing-List: contact dev-help@flume.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flume.apache.org Delivered-To: mailing list dev@flume.apache.org Received: (qmail 78559 invoked by uid 99); 9 Aug 2016 12:10:17 -0000 Received: from reviews-vm.apache.org (HELO reviews.apache.org) (140.211.11.40) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Aug 2016 12:10:17 +0000 Received: from reviews.apache.org (localhost [127.0.0.1]) by reviews.apache.org (Postfix) with ESMTP id 6869F2CB016; Tue, 9 Aug 2016 12:10:17 +0000 (UTC) Content-Type: multipart/alternative; boundary="===============6633463323700190912==" MIME-Version: 1.0 Subject: Re: Review Request 50564: Patch for FLUME-2844 - ChannelCounter of SpillableMemoryChannel doesn't register actually. From: =?utf-8?q?Bal=C3=A1zs_Don=C3=A1t_Bessenyei?= To: Mike Percy , Attila Simon , =?utf-8?q?Bal=C3=A1zs_Don=C3=A1t_Bessenyei?= Cc: Flume , Denes Arvay Date: Tue, 09 Aug 2016 12:10:17 -0000 Message-ID: <20160809121017.1724.76163@reviews.apache.org> X-ReviewBoard-URL: https://reviews.apache.org/ Auto-Submitted: auto-generated Sender: =?utf-8?q?Bal=C3=A1zs_Don=C3=A1t_Bessenyei_=3Cnoreply=40reviews=2Ea?=@reviews.apache.org, =?utf-8?q?pache=2Eorg=3E?=@reviews.apache.org X-ReviewGroup: Flume X-Auto-Response-Suppress: DR, RN, OOF, AutoReply X-ReviewRequest-URL: https://reviews.apache.org/r/50564/ X-Sender: =?utf-8?q?Bal=C3=A1zs_Don=C3=A1t_Bessenyei_=3Cnoreply=40reviews?= =?utf-8?b?LmFwYWNoZS5vcmc+?= References: <20160728125716.11792.35883@reviews.apache.org> In-Reply-To: <20160728125716.11792.35883@reviews.apache.org> Reply-To: =?utf-8?q?Bal=C3=A1zs_Don=C3=A1t_Bessenyei_=3Cbessbd=40cloudera?=@reviews.apache.org, =?utf-8?b?LmNvbT4=?=@reviews.apache.org X-ReviewRequest-Repository: flume-git archived-at: Tue, 09 Aug 2016 12:10:19 -0000 --===============6633463323700190912== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50564/#review145202 ----------------------------------------------------------- flume-ng-channels/flume-spillable-memory-channel/src/test/java/org/apache/flume/channel/TestSpillableMemoryChannel.java (lines 685 - 687) The (modified) tests seem to be running fine without the change in SpillableMemoryChannel.java. - Balázs Donát Bessenyei On July 28, 2016, 12:57 p.m., Denes Arvay wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50564/ > ----------------------------------------------------------- > > (Updated July 28, 2016, 12:57 p.m.) > > > Review request for Flume, Balázs Donát Bessenyei, Mike Percy, and Attila Simon. > > > Bugs: FLUME-2844 > https://issues.apache.org/jira/browse/FLUME-2844 > > > Repository: flume-git > > > Description > ------- > > Patch for FLUME-2844 - ChannelCounter of SpillableMemoryChannel doesn't register actually. > > > Diffs > ----- > > flume-ng-channels/flume-spillable-memory-channel/src/main/java/org/apache/flume/channel/SpillableMemoryChannel.java b46d646 > flume-ng-channels/flume-spillable-memory-channel/src/test/java/org/apache/flume/channel/TestSpillableMemoryChannel.java 848636b > > Diff: https://reviews.apache.org/r/50564/diff/ > > > Testing > ------- > > - checkstyle passes > - `flume-ng-channels` tests pass > > > Thanks, > > Denes Arvay > > --===============6633463323700190912==--