flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Denes Arvay <de...@cloudera.com>
Subject Review Request 51204: FLUME-2973: Deadlock in hdfs sink
Date Thu, 18 Aug 2016 12:56:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51204/
-----------------------------------------------------------

Review request for Flume, Balázs Donát Bessenyei, Mike Percy, and Attila Simon.


Bugs: FLUME-2973
    https://issues.apache.org/jira/browse/FLUME-2973


Repository: flume-git


Description
-------

Automatic close of BucketWriters (when open file count reached `hdfs.maxOpenFiles`) and the
file rolling thread can end up in deadlock.


Diffs
-----

  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
b096410 
  flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java
741f01e 
  flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java
742deb0 

Diff: https://reviews.apache.org/r/51204/diff/


Testing
-------

`flume-hdfs-sink` tests pass. No new tests were added.
I created this script to validate the solution: https://gist.github.com/adenes/96503a6e737f9604ab3ee9397a5809ff


Thanks,

Denes Arvay


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message