flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Balázs Donát Bessenyei <bes...@cloudera.com>
Subject Re: Review Request 50562: Patch for FLUME-2797 - SyslogTcpSource uses Deprecated Class + Deprecate Syslog Source
Date Wed, 10 Aug 2016 10:13:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50562/#review145325
-----------------------------------------------------------




flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java (line 214)
<https://reviews.apache.org/r/50562/#comment211516>

    I think, some logging could be useful here.


- Balázs Donát Bessenyei


On July 29, 2016, 3:10 p.m., Denes Arvay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50562/
> -----------------------------------------------------------
> 
> (Updated July 29, 2016, 3:10 p.m.)
> 
> 
> Review request for Flume, Balázs Donát Bessenyei, Mike Percy, and Attila Simon.
> 
> 
> Bugs: FLUME-2797
>     https://issues.apache.org/jira/browse/FLUME-2797
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Patch for FLUME-2797 - SyslogTcpSource uses Deprecated Class + Deprecate SyslogTCPSource
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java 185c00c 
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogUDPSource.java 175bebb 
>   flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java 10ef8d8

>   flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java e5b7a06

> 
> Diff: https://reviews.apache.org/r/50562/diff/
> 
> 
> Testing
> -------
> 
> - checkstyle passes
> - `flume-ng-core` tests pass
> - 2 new tests added
> 
> 
> Thanks,
> 
> Denes Arvay
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message