flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Balázs Donát Bessenyei <bes...@cloudera.com>
Subject Re: Review Request 50564: Patch for FLUME-2844 - ChannelCounter of SpillableMemoryChannel doesn't register actually.
Date Tue, 09 Aug 2016 12:10:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50564/#review145202
-----------------------------------------------------------




flume-ng-channels/flume-spillable-memory-channel/src/test/java/org/apache/flume/channel/TestSpillableMemoryChannel.java
(lines 685 - 687)
<https://reviews.apache.org/r/50564/#comment211351>

    The (modified) tests seem to be running fine without the change in SpillableMemoryChannel.java.


- Balázs Donát Bessenyei


On July 28, 2016, 12:57 p.m., Denes Arvay wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50564/
> -----------------------------------------------------------
> 
> (Updated July 28, 2016, 12:57 p.m.)
> 
> 
> Review request for Flume, Balázs Donát Bessenyei, Mike Percy, and Attila Simon.
> 
> 
> Bugs: FLUME-2844
>     https://issues.apache.org/jira/browse/FLUME-2844
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Patch for FLUME-2844 - ChannelCounter of SpillableMemoryChannel doesn't register actually.
> 
> 
> Diffs
> -----
> 
>   flume-ng-channels/flume-spillable-memory-channel/src/main/java/org/apache/flume/channel/SpillableMemoryChannel.java
b46d646 
>   flume-ng-channels/flume-spillable-memory-channel/src/test/java/org/apache/flume/channel/TestSpillableMemoryChannel.java
848636b 
> 
> Diff: https://reviews.apache.org/r/50564/diff/
> 
> 
> Testing
> -------
> 
> - checkstyle passes
> - `flume-ng-channels` tests pass
> 
> 
> Thanks,
> 
> Denes Arvay
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message