flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Attila Simon <s...@cloudera.com>
Subject Re: Review Request 50378: FLUME-2960: Support Wildcards in directoryname in TaildirSource
Date Tue, 26 Jul 2016 15:06:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50378/#review143531
-----------------------------------------------------------




flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java
(lines 123 - 127)
<https://reviews.apache.org/r/50378/#comment209346>

    Please add a logging statement that you overrode a configurable parameter. Also please
use a utility function with a self documenting name or add some comment what is the idea behind
this check. (Probably both would be the best)



flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java
(line 241)
<https://reviews.apache.org/r/50378/#comment209349>

    Sorry I didn't meant you to add this test because it is suboptimal (using channel and
transactions just to check matching files). I just altered your existing test because I thought
it will help getting to the point. 
    
    Please check out TestTaildirMatcher class instead for copy paste ready examples.


- Attila Simon


On July 25, 2016, 3:40 p.m., qiao wen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50378/
> -----------------------------------------------------------
> 
> (Updated July 25, 2016, 3:40 p.m.)
> 
> 
> Review request for Flume.
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> In our log management project, we wan't to track many log files like this:
> /app/dir1/log.*
> /app/dir2/log.*
> ...
> /app/dirn/log.*
> But TaildirSource can't support wildcards in filegroup directory name. The following
config is expected:
> a1.sources.r1.filegroups.fg = /app/*/log.*
> 
> 
> Diffs
> -----
> 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst 1334500 
>   flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java
ad9f720 
>   flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java
097ee0b 
> 
> Diff: https://reviews.apache.org/r/50378/diff/
> 
> 
> Testing
> -------
> 
> All tests in TestTaildirSource passed.
> 
> 
> Thanks,
> 
> qiao wen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message