flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mike Percy <mpe...@apache.org>
Subject Re: Review Request 34200: Review request for FLUME-2689, reloading conf file leads syslogTcpSource not receives any event
Date Tue, 26 Jul 2016 08:49:51 GMT


> On July 26, 2016, 1:48 a.m., Mike Percy wrote:
> > Thanks for updating the patch, tinawenqiao. I will try to let Donat take another
look if he has time before I do a final review pass.
> > 
> > Regards, Mike

Oops, I am sorry, I mean Wei Yang. I mixed up this patch with another patch currently under
review. Thank you.


- Mike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34200/#review143498
-----------------------------------------------------------


On July 26, 2016, 1:30 a.m., wei yang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34200/
> -----------------------------------------------------------
> 
> (Updated July 26, 2016, 1:30 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Bugs: FLUME-2689
>     https://issues.apache.org/jira/browse/FLUME-2689
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Reloading conf file will stop old syslog source and start new syslog source. Stopping
syslog tcp source only closes the NioServerSocketChannel, resulting in the client sends data
through the old channel. In that case, the new source never receives data. The tcpdump shows
the events have received but the new source doesn't and ss shows the client connection stays
same with old one.
> The right way to stop syslog source is close both the NioSocketChannel and NioServerSocketChannel,
and shutdown the executor.
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/source/SyslogTcpSource.java e84e4b6 
>   flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java 22fa200

> 
> Diff: https://reviews.apache.org/r/34200/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> wei yang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message