flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Denes Arvay <de...@cloudera.com>
Subject Re: Review Request 50134: FLUME-2955:Add file path to the header in TaildirSource
Date Tue, 19 Jul 2016 14:27:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50134/#review142750
-----------------------------------------------------------


Fix it, then Ship it!




I had one comment, otherwise +1, ship it!


flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java
(line 302)
<https://reviews.apache.org/r/50134/#comment208376>

    I don't see the added value of having a `Boolean` instead of `boolean` here but it introduces
a possible `NPEx` in line 350
    Could you please change it back to `boolean`?
    Otherwise +1 and thanks for the changes.


- Denes Arvay


On July 19, 2016, 3 a.m., qiao wen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50134/
> -----------------------------------------------------------
> 
> (Updated July 19, 2016, 3 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Bugs: FLUME-2955
>     https://issues.apache.org/jira/browse/FLUME-2955
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Log file path is necessary to locate the log. Add a parameter PATH_HEADER in the TaildirSourceConstants.
If the parameter is true, the file path will be added to the header of flume event. Defaut
value is false.
> 
> 
> Diffs
> -----
> 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst f9ca1b2 
>   flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/ReliableTaildirEventReader.java
1409f25 
>   flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSource.java
eae1b1a 
>   flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirSourceConfigurationConstants.java
2c49540 
>   flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java
e090b74 
> 
> Diff: https://reviews.apache.org/r/50134/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install -DskipTests -> built
> junit tests for flume-taildir-source module -> passed
> 
> 
> Thanks,
> 
> qiao wen
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message