flume-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Attila Simon <s...@cloudera.com>
Subject Re: Review Request 49025: FLUME-1899: Make SpoolDir work with Sub-Directories
Date Wed, 22 Jun 2016 12:29:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49025/#review139058
-----------------------------------------------------------


Ship it!




Ship It!

- Attila Simon


On June 22, 2016, 12:24 p.m., Balázs Donát Bessenyei wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49025/
> -----------------------------------------------------------
> 
> (Updated June 22, 2016, 12:24 p.m.)
> 
> 
> Review request for Flume, Denes Arvay, Mike Percy, and Attila Simon.
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> SpoolrDir currently monitors a directory and can not handle sub-directories. This JIRA
is to make SpoolDir able to walk down a source directory and monitor new files.
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java
d54f415 
>   flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java 3fe947d

>   flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySourceConfigurationConstants.java
5053697 
>   flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java fe530ff

>   flume-ng-doc/sphinx/FlumeUserGuide.rst 74d2887 
> 
> Diff: https://reviews.apache.org/r/49025/diff/
> 
> 
> Testing
> -------
> 
> Ran tests before the patch:
> # mvn clean install -DskipTests -Drat.skip=true; mvn -pl flume-ng-core -Drat.skip=true
test
> Tests run: 378, Failures: 0, Errors: 0, Skipped: 2
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 07:55 min
> [INFO] Finished at: 2016-06-21T16:13:46+02:00
> [INFO] Final Memory: 35M/510M
> [INFO] ------------------------------------------------------------------------
> 
> After patch:
> # mvn clean install -DskipTests -Drat.skip=true; mvn -pl flume-ng-core -Drat.skip=true
test
> Tests run: 380, Failures: 0, Errors: 0, Skipped: 2
> 
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 06:18 min
> [INFO] Finished at: 2016-06-21T17:04:17+02:00
> [INFO] Final Memory: 35M/511M
> [INFO] ------------------------------------------------------------------------
> 
> Patch also includes docs
> 
> 
> Thanks,
> 
> Balázs Donát Bessenyei
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message