flume-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mpe...@apache.org
Subject flume git commit: FLUME-2427. Be less verbose in isFileClosed() notification [Forced Update!]
Date Fri, 17 Feb 2017 01:07:49 GMT
Repository: flume
Updated Branches:
  refs/heads/trunk 9604c5ae1 -> 630083228 (forced update)


FLUME-2427. Be less verbose in isFileClosed() notification

Some versions of HDFS and implementations of FileSystem do not implement
the isFileClosed() method.

We perform a check for that method each time a new file is opened. This
patch lowers the severity of the message printed when we detect that the
method is not present from LOG.warn() to LOG.info().

We also remove the stack trace from the log message.

(Ping Wang via Mike Percy)


Project: http://git-wip-us.apache.org/repos/asf/flume/repo
Commit: http://git-wip-us.apache.org/repos/asf/flume/commit/63008322
Tree: http://git-wip-us.apache.org/repos/asf/flume/tree/63008322
Diff: http://git-wip-us.apache.org/repos/asf/flume/diff/63008322

Branch: refs/heads/trunk
Commit: 630083228364f6cd5dc18839fbd4b167cb615b38
Parents: f215374
Author: Ping Wang <wpwang@cn.ibm.com>
Authored: Thu Feb 16 16:53:05 2017 -0800
Committer: Mike Percy <mpercy@apache.org>
Committed: Thu Feb 16 17:07:31 2017 -0800

----------------------------------------------------------------------
 .../main/java/org/apache/flume/sink/hdfs/BucketWriter.java   | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flume/blob/63008322/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
----------------------------------------------------------------------
diff --git a/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
b/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
index 300496a..f6b1734 100644
--- a/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
+++ b/flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
@@ -198,10 +198,10 @@ class BucketWriter {
       return fileSystem.getClass().getMethod("isFileClosed",
         Path.class);
     } catch (Exception e) {
-      LOG.warn("isFileClosed is not available in the " +
-          "version of HDFS being used. Flume will not " +
-          "attempt to close files if the close fails on " +
-          "the first attempt",e);
+      LOG.info("isFileClosed() is not available in the version of the " +
+               "distributed filesystem being used. " +
+               "Flume will not attempt to re-close files if the close fails " +
+               "on the first attempt");
       return null;
     }
   }


Mime
View raw message