flume-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From br...@apache.org
Subject [1/3] git commit: Cleanup uneeded code
Date Thu, 20 Dec 2012 17:51:31 GMT
Updated Branches:
  refs/heads/FLUME-1787 4c953da20 -> 5ccd59fe3


Cleanup uneeded code


Project: http://git-wip-us.apache.org/repos/asf/flume/repo
Commit: http://git-wip-us.apache.org/repos/asf/flume/commit/5ccd59fe
Tree: http://git-wip-us.apache.org/repos/asf/flume/tree/5ccd59fe
Diff: http://git-wip-us.apache.org/repos/asf/flume/diff/5ccd59fe

Branch: refs/heads/FLUME-1787
Commit: 5ccd59fe3aa292f5c01625cf445c337a0721db0f
Parents: 4b7fd0e
Author: Brock Noland <brock@apache.org>
Authored: Thu Dec 20 11:51:20 2012 -0600
Committer: Brock Noland <brock@apache.org>
Committed: Thu Dec 20 11:51:20 2012 -0600

----------------------------------------------------------------------
 dev-support/test-patch.py |   17 ++++-------------
 1 files changed, 4 insertions(+), 13 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flume/blob/5ccd59fe/dev-support/test-patch.py
----------------------------------------------------------------------
diff --git a/dev-support/test-patch.py b/dev-support/test-patch.py
index 2c253fa..4583a63 100755
--- a/dev-support/test-patch.py
+++ b/dev-support/test-patch.py
@@ -128,18 +128,12 @@ def git_apply(result, cmd, patch_file, strip, output_dir):
     result.fatal("failed to apply patch (exit code %d):\n%s\n" % (rc, output))
 
 def mvn_clean(result, output_dir):
-  if output_dir:
-    rc = execute("mvn clean 1>%s/clean.out 2>&1" % output_dir)
-  else:
-    rc = execute("mvn clean")
+  rc = execute("mvn clean 1>%s/clean.out 2>&1" % output_dir)
   if rc != 0:
-    result.fatal("failed to clean project (exit code %d" % (rc))
+    result.fatal("failed to clean project (exit code %d)" % (rc))
 
 def mvn_install(result, output_dir):
-  if output_dir:
-    rc = execute("mvn install -DskipTests 1>%s/install.out 2>&1" % output_dir)
-  else:
-    rc = execute("mvn install -DskipTests")
+  rc = execute("mvn install -DskipTests 1>%s/install.out 2>&1" % output_dir)
   if rc != 0:
     result.fatal("failed to build with patch (exit code %d)" % (rc))
 
@@ -149,10 +143,7 @@ def find_all_files(top):
             yield os.path.join(root, f)
 
 def mvn_test(result, output_dir):
-  if output_dir:
-    rc = execute("mvn test 1>%s/test.out 2>&1" % output_dir)
-  else:
-    rc = execute("mvn test")
+  rc = execute("mvn test 1>%s/test.out 2>&1" % output_dir)
   if rc == 0:
     result.success("all tests passed")
   else:


Mime
View raw message